[NaCl SDK] Fix PNACL for debugging.

native_client_sdk/src/tools/common.mk

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 #
 # GNU Make based build file.  For details on GNU Make see:
 #   http://www.gnu.org/software/make/manual/make.html
 #
 
 #
@@ skipping 459 matching lines @@
 run: check_for_chrome all $(PAGE)
         $(RUN_PY) -C $(CURDIR) -P $(PAGE_TC_CONFIG) \
             $(addprefix -E ,$(CHROME_ENV)) -- $(CHROME_PATH) $(CHROME_ARGS) \
             --register-pepper-plugins="$(PPAPI_DEBUG),$(PPAPI_RELEASE)"
 
 .PHONY: run_package
 run_package: check_for_chrome all
         $(CHROME_PATH) --load-and-launch-app=$(CURDIR) $(CHROME_ARGS)
 
 
-GDB_ARGS += -D $(TC_PATH)/$(OSNAME)_x86_$(TOOLCHAIN)/bin/$(SYSARCH)-nacl-gdb
+# name gdb for everyone ?!?!?

[Sam Clegg, 2013/08/10 00:54:01]

/name/same/.   Perhaps a better comment?  Perhaps TODO() ship just a single
version of gdb outside the toolchain folder, or use symlinks to an outside one.

[noelallen1, 2013/08/10 19:08:49]

Adding a bug to fix this.
BUG=271183

+GDB_ARGS += -D $(TC_PATH)/$(OSNAME)_x86_newlib/bin/$(SYSARCH)-nacl-gdb
 GDB_ARGS += -D $(abspath $(OUTDIR))/$(TARGET)_$(SYSARCH).nexe
 
 .PHONY: debug
 debug: check_for_chrome all $(PAGE)
         $(RUN_PY) $(GDB_ARGS) \
             -C $(CURDIR) -P $(PAGE_TC_CONFIG) \
             $(addprefix -E ,$(CHROME_ENV)) -- $(CHROME_PATH) $(CHROME_ARGS) \
             --enable-nacl-debug \
             --register-pepper-plugins="$(PPAPI_DEBUG),$(PPAPI_RELEASE)"
 endif
 
 
 # uppercase aliases (for backward compatibility)
 .PHONY: CHECK_FOR_CHROME DEBUG LAUNCH RUN
 CHECK_FOR_CHROME: check_for_chrome
 DEBUG: debug
 LAUNCH: run
 RUN: run
 
 endif  # TOOLCHAIN is valid...
 
 endif  # TOOLCHAIN=all