Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: components/ntp_snippets/ntp_snippets_service.h

Issue 2276383002: Support server-provided category names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/ntp_snippets_service.h
diff --git a/components/ntp_snippets/ntp_snippets_service.h b/components/ntp_snippets/ntp_snippets_service.h
index b0ce9d1d91864af54789da921d74952d58212fa3..140413ea75ed2ad0bd53ea5748be3c058c8ef6e8 100644
--- a/components/ntp_snippets/ntp_snippets_service.h
+++ b/components/ntp_snippets/ntp_snippets_service.h
@@ -295,6 +295,11 @@ class NTPSnippetsService : public ContentSuggestionsProvider,
struct CategoryContent {
CategoryStatus status = CategoryStatus::INITIALIZING;
+ // For server-side categories, the title of the section, localized to the
+ // running UI language. Ignored for categories known to the client (i.e.
tschumann 2016/08/25 16:46:31 hm... the last sentence is a bit confusing. For ar
sfiera 2016/08/26 09:16:15 Ah, actually, it's a mistake for this comment to b
+ // ARTICLES).
+ base::string16 localized_title;
+
// True iff the server returned results in this category in the last fetch.
// We never remove categories that the server still provides, but if the
// server stops providing a category, we won't yet report it as NOT_PROVIDED

Powered by Google App Engine
This is Rietveld 408576698