Support server-provided category names.

components/ntp_snippets/ntp_snippets_service.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NTP_SNIPPETS_NTP_SNIPPETS_SERVICE_H_
 #define COMPONENTS_NTP_SNIPPETS_NTP_SNIPPETS_SERVICE_H_
 
 #include <stddef.h>
 
 #include <memory>
@@ skipping 277 matching lines @@
 
   PrefService* pref_service_;
 
   suggestions::SuggestionsService* suggestions_service_;
 
   const Category articles_category_;
 
   struct CategoryContent {
     CategoryStatus status = CategoryStatus::INITIALIZING;
 
+    // For server-side categories, the title of the section, localized to the
+    // running UI language. Ignored for categories known to the client (i.e.

[tschumann, 2016/08/25 16:46:31]

hm... the last sentence is a bit confusing. For articles you also set this
property. It would be nice if we could reduce the implications of
server-provided categories to a minimum. So simply enforce this to be always
present?

[sfiera, 2016/08/26 09:16:15]

Ah, actually, it's a mistake for this comment to be here. It's in
FetchedCategory that localized_title is ignored. Fixed, thanks.

+    // ARTICLES).
+    base::string16 localized_title;
+
     // True iff the server returned results in this category in the last fetch.
     // We never remove categories that the server still provides, but if the
     // server stops providing a category, we won't yet report it as NOT_PROVIDED
     // while we still have non-expired snippets in it.
     bool provided_by_server = true;
 
     // All current suggestions (i.e. not dismissed ones).
     NTPSnippet::PtrVector snippets;
 
     // Suggestions that the user dismissed. We keep these around until they
@@ skipping 50 matching lines @@
 
   // Request throttler for limiting requests to thumbnail images.
   RequestThrottler thumbnail_requests_throttler_;
 
   DISALLOW_COPY_AND_ASSIGN(NTPSnippetsService);
 };
 
 }  // namespace ntp_snippets
 
 #endif  // COMPONENTS_NTP_SNIPPETS_NTP_SNIPPETS_SERVICE_H_