Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2276343005: Delete MediaCodecPlayer, it's time! (Closed)

Created:
4 years, 3 months ago by DaleCurtis
Modified:
4 years, 3 months ago
Reviewers:
Tima Vaisburd
CC:
avayvod+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mlamouri+watch-media_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete MediaCodecPlayer, it's time! Spitzer has been launched since M52 w/o issue; it's time to start cleaning up the old code paths. This saves ~77kb of APK size! BUG=570711 TEST=compile Committed: https://crrev.com/cbdfa25c7526a8ddddba3fc6a84c17b25263d48e Cr-Commit-Position: refs/heads/master@{#414582}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8132 lines) Patch
M content/browser/media/android/browser_demuxer_android.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 3 chunks +6 lines, -20 lines 0 comments Download
M media/base/android/BUILD.gn View 5 chunks +0 lines, -18 lines 0 comments Download
D media/base/android/access_unit_queue.h View 1 chunk +0 lines, -112 lines 0 comments Download
D media/base/android/access_unit_queue.cc View 1 chunk +0 lines, -211 lines 0 comments Download
D media/base/android/access_unit_queue_unittest.cc View 1 chunk +0 lines, -366 lines 0 comments Download
D media/base/android/audio_media_codec_decoder.h View 1 chunk +0 lines, -103 lines 0 comments Download
D media/base/android/audio_media_codec_decoder.cc View 1 chunk +0 lines, -336 lines 0 comments Download
D media/base/android/media_codec_decoder.h View 1 chunk +0 lines, -470 lines 0 comments Download
D media/base/android/media_codec_decoder.cc View 1 chunk +0 lines, -1009 lines 0 comments Download
D media/base/android/media_codec_decoder_unittest.cc View 1 chunk +0 lines, -770 lines 0 comments Download
D media/base/android/media_codec_player.h View 1 chunk +0 lines, -429 lines 0 comments Download
D media/base/android/media_codec_player.cc View 1 chunk +0 lines, -1422 lines 0 comments Download
D media/base/android/media_codec_player_unittest.cc View 1 chunk +0 lines, -2283 lines 0 comments Download
D media/base/android/media_task_runner.h View 1 chunk +0 lines, -22 lines 0 comments Download
D media/base/android/media_task_runner.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D media/base/android/video_media_codec_decoder.h View 1 chunk +0 lines, -130 lines 0 comments Download
D media/base/android/video_media_codec_decoder.cc View 1 chunk +0 lines, -359 lines 0 comments Download
M media/base/media_switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/media_switches.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
DaleCurtis
Thanks for your contribution timav@. Sorry this didn't end up being used! Are there any ...
4 years, 3 months ago (2016-08-25 19:46:42 UTC) #2
Tima Vaisburd
On 2016/08/25 19:46:42, DaleCurtis wrote: > Thanks for your contribution timav@. Sorry this didn't end ...
4 years, 3 months ago (2016-08-25 23:00:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276343005/1
4 years, 3 months ago (2016-08-25 23:03:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 23:25:38 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 23:27:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbdfa25c7526a8ddddba3fc6a84c17b25263d48e
Cr-Commit-Position: refs/heads/master@{#414582}

Powered by Google App Engine
This is Rietveld 408576698