Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2276323002: Treat all kArchNop instuctions as NOPs in jump threading. (Closed)

Created:
4 years, 3 months ago by georgia.kouveli
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Treat all kArchNop instuctions as NOPs in jump threading. BUG= Committed: https://crrev.com/ede28d900caf2d63922fdc84bbb4bd05978a76a3 Cr-Commit-Position: refs/heads/master@{#38902}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M src/compiler/instruction.h View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
georgia.kouveli
This improves code generation for stubs and bytecode handlers (for example in AddStub, SubtractStub, IncStub, ...
4 years, 3 months ago (2016-08-25 09:33:07 UTC) #2
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-08-25 11:15:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276323002/1
4 years, 3 months ago (2016-08-25 11:15:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 11:48:52 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 11:49:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ede28d900caf2d63922fdc84bbb4bd05978a76a3
Cr-Commit-Position: refs/heads/master@{#38902}

Powered by Google App Engine
This is Rietveld 408576698