Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: src/compiler/instruction.h

Issue 2276323002: Treat all kArchNop instuctions as NOPs in jump threading. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/instruction.h
diff --git a/src/compiler/instruction.h b/src/compiler/instruction.h
index b5aea707d2e3ac21ff6f5f9db52faa06e22d9157..74efd86fbecef0510076425900b4a1d6743003ac 100644
--- a/src/compiler/instruction.h
+++ b/src/compiler/instruction.h
@@ -856,10 +856,7 @@ class Instruction final {
reference_map_ = nullptr;
}
- bool IsNop() const {
- return arch_opcode() == kArchNop && InputCount() == 0 &&
- OutputCount() == 0 && TempCount() == 0;
- }
+ bool IsNop() const { return arch_opcode() == kArchNop; }
bool IsDeoptimizeCall() const {
return arch_opcode() == ArchOpcode::kArchDeoptimize ||
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698