Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2276293002: Revert of Add ARC++ specific fields to launch data for specific apps. (Closed)

Created:
4 years, 3 months ago by haraken
Modified:
4 years, 3 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, extensions-reviews_chromium.org, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add ARC++ specific fields to launch data for specific apps. (patchset #7 id:120001 of https://codereview.chromium.org/2272813003/ ) Reason for revert: This broke compilation of ChromeOS: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/22483 Original issue's description: > Add ARC++ specific fields to launch data for specific apps. > > On devices that have ARC++ available or enabled, certain internal apps need > to be able to get this information. Currently these are limited to the > GetHelp and the demo app. > > These are fields we'd like to eventually just expose to all apps but currently > security is not comfortable with that yet, so for now, we'll set these flags > only for the apps that currently need it. > > Reviews requested, > xiyuan@ - General review. > asargent@ - //apps and extension parts > lhchavez@ - ARC++ parts > sky@ - //chrome/browser/ui > > R=asargent@chromium.org, lhchavez@chromium.org, sky@chromium.org, xiyuan@chromium.org > BUG=640330 > > Committed: https://crrev.com/3d97de469a486debcb8956de8f7ed679fa862cbf > Cr-Commit-Position: refs/heads/master@{#414348} TBR=asargent@chromium.org,lhchavez@chromium.org,sky@chromium.org,xiyuan@chromium.org,rkc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=640330 Committed: https://crrev.com/ffd6f574540628307c652b24895e32c903ebf3c2 Cr-Commit-Position: refs/heads/master@{#414351}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -101 lines) Patch
M apps/launcher.h View 2 chunks +5 lines, -10 lines 0 comments Download
M apps/launcher.cc View 6 chunks +7 lines, -17 lines 0 comments Download
M chrome/browser/apps/app_launch_for_metro_restart_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/demo_mode/demo_app_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/chrome_pages.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/ui/extensions/app_launch_params.h View 3 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/ui/extensions/app_launch_params.cc View 2 chunks +2 lines, -22 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M components/arc/arc_bridge_service.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/arc/arc_bridge_service.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M extensions/browser/api/app_runtime/app_runtime_api.h View 2 chunks +1 line, -2 lines 0 comments Download
M extensions/browser/api/app_runtime/app_runtime_api.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M extensions/common/api/app_runtime.idl View 2 chunks +0 lines, -13 lines 0 comments Download
M extensions/shell/browser/shell_extension_system.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
haraken
Created Revert of Add ARC++ specific fields to launch data for specific apps.
4 years, 3 months ago (2016-08-25 07:46:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276293002/1
4 years, 3 months ago (2016-08-25 07:47:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 07:47:59 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 07:49:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffd6f574540628307c652b24895e32c903ebf3c2
Cr-Commit-Position: refs/heads/master@{#414351}

Powered by Google App Engine
This is Rietveld 408576698