Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1967)

Unified Diff: apps/launcher.cc

Issue 2276293002: Revert of Add ARC++ specific fields to launch data for specific apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « apps/launcher.h ('k') | chrome/browser/apps/app_launch_for_metro_restart_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/launcher.cc
diff --git a/apps/launcher.cc b/apps/launcher.cc
index 1ac5aef27947de679163f78d81d4f6998fe81ea3..6904f0f0cd8f5226b6466c33759d95e699dd81d6 100644
--- a/apps/launcher.cc
+++ b/apps/launcher.cc
@@ -12,7 +12,6 @@
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/logging.h"
-#include "base/memory/ptr_util.h"
#include "base/memory/ref_counted.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
@@ -49,7 +48,6 @@
using content::BrowserThread;
using extensions::AppRuntimeEventRouter;
-using extensions::api::app_runtime::PlayStoreStatus;
using extensions::app_file_handler_util::CreateFileEntry;
using extensions::app_file_handler_util::FileHandlerCanHandleEntry;
using extensions::app_file_handler_util::FileHandlerForId;
@@ -205,12 +203,8 @@
if (!app)
return;
- std::unique_ptr<app_runtime::LaunchData> launch_data =
- base::MakeUnique<app_runtime::LaunchData>();
- launch_data->action_data = std::move(action_data_);
-
AppRuntimeEventRouter::DispatchOnLaunchedEvent(
- profile_, app, launch_source_, std::move(launch_data));
+ profile_, app, launch_source_, std::move(action_data_));
}
void OnAreDirectoriesCollected(
@@ -358,11 +352,10 @@
} // namespace
void LaunchPlatformAppWithCommandLine(Profile* profile,
- const extensions::Extension* app,
+ const Extension* app,
const base::CommandLine& command_line,
const base::FilePath& current_directory,
- extensions::AppLaunchSource source,
- PlayStoreStatus play_store_status) {
+ extensions::AppLaunchSource source) {
// An app with "kiosk_only" should not be installed and launched
// outside of ChromeOS kiosk mode in the first place. This is a defensive
// check in case this scenario does occur.
@@ -393,12 +386,8 @@
// causes problems on the bots.
if (args.empty() || (command_line.HasSwitch(switches::kTestType) &&
args[0] == about_blank_url)) {
- std::unique_ptr<app_runtime::LaunchData> launch_data =
- base::MakeUnique<app_runtime::LaunchData>();
- if (play_store_status != PlayStoreStatus::PLAY_STORE_STATUS_UNKNOWN)
- launch_data->play_store_status = play_store_status;
- AppRuntimeEventRouter::DispatchOnLaunchedEvent(profile, app, source,
- std::move(launch_data));
+ AppRuntimeEventRouter::DispatchOnLaunchedEvent(
+ profile, app, source, std::unique_ptr<app_runtime::ActionData>());
return;
}
@@ -465,7 +454,8 @@
if (listening_to_launch && had_windows) {
AppRuntimeEventRouter::DispatchOnLaunchedEvent(
- profile, app, extensions::SOURCE_RESTART, nullptr);
+ profile, app, extensions::SOURCE_RESTART,
+ std::unique_ptr<app_runtime::ActionData>());
}
}
« no previous file with comments | « apps/launcher.h ('k') | chrome/browser/apps/app_launch_for_metro_restart_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698