Permission Action Reporting: Test num_prior* metrics are recorded correctly.

Permission Action Reporting: Test num_prior* metrics are recorded correctly.

This test ensures that the change in cl/2267353002 is maintained in the correct order.

BUG=613883, 638076
Committed: https://crrev.com/2fcb04a7eabd49c59a9b25edd7303973d01523b1
Cr-Commit-Position: refs/heads/master@{#416223}

[kcarattini, 2016-08-25 01:14:59]

kcarattini@chromium.org changed reviewers:
+ nparker@chromium.org

[raymes, 2016-08-25 05:29:00]

raymes@chromium.org changed reviewers:
+ raymes@chromium.org

[raymes, 2016-08-25 05:29:00]

Thanks for writing this Kendra!

[raymes, 2016-08-25 05:29:14]

Description was changed from

==========
Permission Action Reporting: Test num_prior* metrics are recorded correctly.

This test ensures that the change in cl/2267353002 is maintained in the correct
order.

BUG=613883,638076
==========

to

==========
Permission Action Reporting: Test num_prior* metrics are recorded correctly.

This test ensures that the change in cl/2267353002 is maintained in the correct
order.

BUG=613883,638076
==========

[raymes, 2016-08-25 05:29:14]

raymes@chromium.org changed reviewers:
- raymes@chromium.org

[kcarattini, 2016-08-31 05:24:53]

Ping to Nathan, PTAL, thanks!

[Nathan Parker, 2016-09-01 18:58:50]

lgtm

https://codereview.chromium.org/2276253002/diff/80001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/permission_reporter_browsertest.cc (right):

https://codereview.chromium.org/2276253002/diff/80001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:175:
EXPECT_EQ(PermissionReport::DESKTOP_PLATFORM,
This got me thinking... are browser tests run on Android? I kinda think they're
not.

[dominickn, 2016-09-02 02:30:34]

On 2016/09/01 18:58:50, Nathan Parker wrote:
> lgtm
> 
>
https://codereview.chromium.org/2276253002/diff/80001/chrome/browser/safe_bro...
> File chrome/browser/safe_browsing/permission_reporter_browsertest.cc (right):
> 
>
https://codereview.chromium.org/2276253002/diff/80001/chrome/browser/safe_bro...
> chrome/browser/safe_browsing/permission_reporter_browsertest.cc:175:
> EXPECT_EQ(PermissionReport::DESKTOP_PLATFORM,
> This got me thinking... are browser tests run on Android? I kinda think
they're
> not.

Browser tests are not run on Android, though there are plans to slowly enable
them (crbug.com/611756).

[kcarattini, 2016-09-02 08:43:35]

The CQ bit was checked by kcarattini@chromium.org

[commit-bot: I haz the power, 2016-09-02 08:43:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 09:37:43]

Description was changed from

==========
Permission Action Reporting: Test num_prior* metrics are recorded correctly.

This test ensures that the change in cl/2267353002 is maintained in the correct
order.

BUG=613883,638076
==========

to

==========
Permission Action Reporting: Test num_prior* metrics are recorded correctly.

This test ensures that the change in cl/2267353002 is maintained in the correct
order.

BUG=613883,638076
==========

[commit-bot: I haz the power, 2016-09-02 09:37:45]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-02 09:39:36]

Description was changed from

==========
Permission Action Reporting: Test num_prior* metrics are recorded correctly.

This test ensures that the change in cl/2267353002 is maintained in the correct
order.

BUG=613883,638076
==========

to

==========
Permission Action Reporting: Test num_prior* metrics are recorded correctly.

This test ensures that the change in cl/2267353002 is maintained in the correct
order.

BUG=613883,638076

Committed: https://crrev.com/2fcb04a7eabd49c59a9b25edd7303973d01523b1
Cr-Commit-Position: refs/heads/master@{#416223}
==========

[commit-bot: I haz the power, 2016-09-02 09:39:37]

Patchset 5 (id:??) landed as
https://crrev.com/2fcb04a7eabd49c59a9b25edd7303973d01523b1
Cr-Commit-Position: refs/heads/master@{#416223}