Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11719)

Unified Diff: device/bluetooth/bluetooth_adapter_mac.mm

Issue 2276213002: bluetooth: Fix mac crash when logging is enabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_adapter_mac.mm
diff --git a/device/bluetooth/bluetooth_adapter_mac.mm b/device/bluetooth/bluetooth_adapter_mac.mm
index ef4a20dee2da1156e992a84add68576b47755754..01364221aa2b6e9f4b7e69c3bc6b046e02835f23 100644
--- a/device/bluetooth/bluetooth_adapter_mac.mm
+++ b/device/bluetooth/bluetooth_adapter_mac.mm
@@ -595,13 +595,15 @@ void BluetoothAdapterMac::DidFailToConnectPeripheral(CBPeripheral* peripheral,
[low_energy_central_manager_ cancelPeripheralConnection:peripheral];
return;
}
- VLOG(1) << "Bluetooth error, domain: " << error.domain.UTF8String
- << ", error code: " << error.code;
+ VLOG(1) << "Failed to connect to peripheral";
BluetoothDevice::ConnectErrorCode error_code =
- BluetoothDeviceMac::GetConnectErrorCodeFromNSError(error);
- VLOG(1) << "Bluetooth error, domain: " << error.domain.UTF8String
- << ", error code: " << error.code
- << ", converted into: " << error_code;
+ BluetoothDevice::ConnectErrorCode::ERROR_UNKNOWN;
Jeffrey Yasskin 2016/08/24 23:28:13 If this happens when we explicitly disconnected wh
ortuno 2016/08/25 16:39:56 We should but I would like to do that in a separat
+ if (error) {
+ error_code = BluetoothDeviceMac::GetConnectErrorCodeFromNSError(error);
+ VLOG(1) << "Bluetooth error, domain: " << error.domain.UTF8String
+ << ", error code: " << error.code
+ << ", converted into: " << error_code;
+ }
device_mac->DidFailToConnectGatt(error_code);
}
@@ -613,11 +615,12 @@ void BluetoothAdapterMac::DidDisconnectPeripheral(CBPeripheral* peripheral,
[low_energy_central_manager_ cancelPeripheralConnection:peripheral];
return;
}
- VLOG(1) << "Bluetooth error, domain: " << error.domain.UTF8String
- << ", error code: " << error.code;
- BluetoothDevice::ConnectErrorCode error_code =
- BluetoothDeviceMac::GetConnectErrorCodeFromNSError(error);
- device_mac->DidDisconnectPeripheral(error_code);
+ VLOG(1) << "Disconnected from peripheral.";
+ if (error) {
+ VLOG(1) << "Bluetooth error, domain: " << error.domain.UTF8String
+ << ", error code: " << error.code;
+ }
+ device_mac->DidDisconnectPeripheral(error);
}
BluetoothLowEnergyDeviceMac*
« no previous file with comments | « no previous file | device/bluetooth/bluetooth_low_energy_device_mac.h » ('j') | device/bluetooth/bluetooth_low_energy_device_mac.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698