bluetooth: Fix mac crash when logging is enabled

device/bluetooth/bluetooth_adapter_mac.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/bluetooth/bluetooth_adapter_mac.h"
 
 #import <IOBluetooth/objc/IOBluetoothDevice.h>
 #import <IOBluetooth/objc/IOBluetoothHostController.h>
 #include <stddef.h>
 
@@ skipping 577 matching lines @@
 }
 
 void BluetoothAdapterMac::DidFailToConnectPeripheral(CBPeripheral* peripheral,
                                                      NSError* error) {
   BluetoothLowEnergyDeviceMac* device_mac =
       GetBluetoothLowEnergyDeviceMac(peripheral);
   if (!device_mac) {
     [low_energy_central_manager_ cancelPeripheralConnection:peripheral];
     return;
   }
-  VLOG(1) << "Bluetooth error, domain: " << error.domain.UTF8String
-          << ", error code: " << error.code;
+  VLOG(1) << "Failed to connect to peripheral";
   BluetoothDevice::ConnectErrorCode error_code =
-      BluetoothDeviceMac::GetConnectErrorCodeFromNSError(error);
-  VLOG(1) << "Bluetooth error, domain: " << error.domain.UTF8String
-          << ", error code: " << error.code
-          << ", converted into: " << error_code;
+      BluetoothDevice::ConnectErrorCode::ERROR_UNKNOWN;

[Jeffrey Yasskin, 2016/08/24 23:28:13]

If this happens when we explicitly disconnected while a connect was pending,
should we use something like ERROR_ABORTED?

[ortuno, 2016/08/25 16:39:56]

We should but I would like to do that in a separate CL that fixes all platforms.
If we were to only fix mac we would also have to change a bunch of tests. I
opened http://crbug.com/641010 to keep track.

+  if (error) {
+    error_code = BluetoothDeviceMac::GetConnectErrorCodeFromNSError(error);
+    VLOG(1) << "Bluetooth error, domain: " << error.domain.UTF8String
+            << ", error code: " << error.code
+            << ", converted into: " << error_code;
+  }
   device_mac->DidFailToConnectGatt(error_code);
 }
 
 void BluetoothAdapterMac::DidDisconnectPeripheral(CBPeripheral* peripheral,
                                                   NSError* error) {
   BluetoothLowEnergyDeviceMac* device_mac =
       GetBluetoothLowEnergyDeviceMac(peripheral);
   if (!device_mac) {
     [low_energy_central_manager_ cancelPeripheralConnection:peripheral];
     return;
   }
-  VLOG(1) << "Bluetooth error, domain: " << error.domain.UTF8String
-          << ", error code: " << error.code;
-  BluetoothDevice::ConnectErrorCode error_code =
-      BluetoothDeviceMac::GetConnectErrorCodeFromNSError(error);
-  device_mac->DidDisconnectPeripheral(error_code);
+  VLOG(1) << "Disconnected from peripheral.";
+  if (error) {
+    VLOG(1) << "Bluetooth error, domain: " << error.domain.UTF8String
+            << ", error code: " << error.code;
+  }
+  device_mac->DidDisconnectPeripheral(error);
 }
 
 BluetoothLowEnergyDeviceMac*
 BluetoothAdapterMac::GetBluetoothLowEnergyDeviceMac(CBPeripheral* peripheral) {
   std::string device_address =
       BluetoothLowEnergyDeviceMac::GetPeripheralHashAddress(peripheral);
   DevicesMap::const_iterator iter = devices_.find(device_address);
   if (iter == devices_.end()) {
     return nil;
   }
   return static_cast<BluetoothLowEnergyDeviceMac*>(iter->second);
 }
 
 }  // namespace device