Support custom message filtering on Mojo binding objects

Support custom message filtering on Mojo binding objects

* Replaces MessageFilter with MessageReceiver
* Updates FilterChain to always end on the sink, short-circuiting
  if any "filter" (receiver) rejects along the way
* Adds a new AddFilter() interface to mojo::Binding and
  mojo::AssociatedBinding, allowing users to inject MessageReceiver
  filters to be run immediately before every message dispatch

BUG=612500
R=yzshen@chromium.org
TBR=tsepez@chromium.org

Committed: https://crrev.com/222e7dd4cce2ad6e583e54638404aedf9126a956
Cr-Commit-Position: refs/heads/master@{#414197}

[Ken Rockot(use gerrit already), 2016-08-24 16:44:23]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 16:44:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-08-24 16:47:40]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 16:48:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 16:50:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 16:50:41]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ken Rockot(use gerrit already), 2016-08-24 16:51:49]

Please take a look. If we get rid of MessageFilter holding a sink reference,
it's just a MessageReceiver, so I removed MessageFilter. Also made FilterChain
be a MessageReceiver itself. I think this simplifies usage and is less confusing
than the prior state. WDYT?

[Ken Rockot(use gerrit already), 2016-08-24 16:56:20]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 16:57:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 17:23:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 17:23:14]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Ken Rockot(use gerrit already), 2016-08-24 18:10:22]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 18:11:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-08-24 20:47:55]

LGTM 

Thanks!

https://codereview.chromium.org/2276043002/diff/60001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/binding.h (right):

https://codereview.chromium.org/2276043002/diff/60001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/binding.h:157: // optionally prevent it from being
dispatched. Filters cannot be removed.
Returning false not just prevents the message from being dispatched, but also
disconnects the pipe.

(I think that behavior is fine for now. Please consider updating the comment)

[Ken Rockot(use gerrit already), 2016-08-24 20:56:22]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-08-24 20:56:22]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2276043002/#ps80001
(title: "comment")

[Ken Rockot(use gerrit already), 2016-08-24 20:56:38]

https://codereview.chromium.org/2276043002/diff/60001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/binding.h (right):

https://codereview.chromium.org/2276043002/diff/60001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/binding.h:157: // optionally prevent it from being
dispatched. Filters cannot be removed.
On 2016/08/24 at 20:47:55, yzshen1 wrote:
> Returning false not just prevents the message from being dispatched, but also
disconnects the pipe.
> 
> (I think that behavior is fine for now. Please consider updating the comment)

Done

[commit-bot: I haz the power, 2016-08-24 20:57:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 21:11:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 21:11:30]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ken Rockot(use gerrit already), 2016-08-24 21:26:15]

Description was changed from

==========
Support custom message filtering on Mojo binding objects

* Replaces MessageFilter with MessageReceiver
* Updates FilterChain to always end on the sink, short-circuiting
  if any "filter" (receiver) rejects along the way
* Adds a new AddFilter() interface to mojo::Binding and
  mojo::AssociatedBinding, allowing users to inject MessageReceiver
  filters to be run immediately before every message dispatch

BUG=612500
R=yzshen@chromium.org
==========

to

==========
Support custom message filtering on Mojo binding objects

* Replaces MessageFilter with MessageReceiver
* Updates FilterChain to always end on the sink, short-circuiting
  if any "filter" (receiver) rejects along the way
* Adds a new AddFilter() interface to mojo::Binding and
  mojo::AssociatedBinding, allowing users to inject MessageReceiver
  filters to be run immediately before every message dispatch

BUG=612500
R=yzshen@chromium.org
TBR=tsepez@chromium.org for test-only mojom
==========

[Ken Rockot(use gerrit already), 2016-08-24 21:26:19]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-08-24 21:27:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-08-24 23:27:55]

Description was changed from

==========
Support custom message filtering on Mojo binding objects

* Replaces MessageFilter with MessageReceiver
* Updates FilterChain to always end on the sink, short-circuiting
  if any "filter" (receiver) rejects along the way
* Adds a new AddFilter() interface to mojo::Binding and
  mojo::AssociatedBinding, allowing users to inject MessageReceiver
  filters to be run immediately before every message dispatch

BUG=612500
R=yzshen@chromium.org
TBR=tsepez@chromium.org for test-only mojom
==========

to

==========
Support custom message filtering on Mojo binding objects

* Replaces MessageFilter with MessageReceiver
* Updates FilterChain to always end on the sink, short-circuiting
  if any "filter" (receiver) rejects along the way
* Adds a new AddFilter() interface to mojo::Binding and
  mojo::AssociatedBinding, allowing users to inject MessageReceiver
  filters to be run immediately before every message dispatch

BUG=612500
R=yzshen@chromium.org
TBR=tsepez@chromium.org
==========

[Ken Rockot(use gerrit already), 2016-08-24 23:28:03]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-08-24 23:28:08]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-08-24 23:28:17]

(TBR tsepez for test-only mojom)

[commit-bot: I haz the power, 2016-08-24 23:28:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 23:37:26]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-24 23:39:52]

Description was changed from

==========
Support custom message filtering on Mojo binding objects

* Replaces MessageFilter with MessageReceiver
* Updates FilterChain to always end on the sink, short-circuiting
  if any "filter" (receiver) rejects along the way
* Adds a new AddFilter() interface to mojo::Binding and
  mojo::AssociatedBinding, allowing users to inject MessageReceiver
  filters to be run immediately before every message dispatch

BUG=612500
R=yzshen@chromium.org
TBR=tsepez@chromium.org
==========

to

==========
Support custom message filtering on Mojo binding objects

* Replaces MessageFilter with MessageReceiver
* Updates FilterChain to always end on the sink, short-circuiting
  if any "filter" (receiver) rejects along the way
* Adds a new AddFilter() interface to mojo::Binding and
  mojo::AssociatedBinding, allowing users to inject MessageReceiver
  filters to be run immediately before every message dispatch

BUG=612500
R=yzshen@chromium.org
TBR=tsepez@chromium.org

Committed: https://crrev.com/222e7dd4cce2ad6e583e54638404aedf9126a956
Cr-Commit-Position: refs/heads/master@{#414197}
==========

[commit-bot: I haz the power, 2016-08-24 23:39:53]

Patchset 5 (id:??) landed as
https://crrev.com/222e7dd4cce2ad6e583e54638404aedf9126a956
Cr-Commit-Position: refs/heads/master@{#414197}