Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: mojo/public/cpp/bindings/lib/binding_state.cc

Issue 2276043002: Support custom message filtering on Mojo binding objects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/bindings/lib/binding_state.h ('k') | mojo/public/cpp/bindings/lib/filter_chain.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/lib/binding_state.cc
diff --git a/mojo/public/cpp/bindings/lib/binding_state.cc b/mojo/public/cpp/bindings/lib/binding_state.cc
index db04dcba8f57439c2c80af08fe97f34d15313dff..2d892a071b1f5125ec473300d5ed44361348ef68 100644
--- a/mojo/public/cpp/bindings/lib/binding_state.cc
+++ b/mojo/public/cpp/bindings/lib/binding_state.cc
@@ -11,6 +11,11 @@ SimpleBindingState::SimpleBindingState() = default;
SimpleBindingState::~SimpleBindingState() = default;
+void SimpleBindingState::AddFilter(std::unique_ptr<MessageReceiver> filter) {
+ DCHECK(router_);
+ router_->AddFilter(std::move(filter));
+}
+
void SimpleBindingState::PauseIncomingMethodCallProcessing() {
DCHECK(router_);
router_->PauseIncomingMethodCallProcessing();
@@ -42,12 +47,12 @@ void SimpleBindingState::BindInternal(
ScopedMessagePipeHandle handle,
scoped_refptr<base::SingleThreadTaskRunner> runner,
const char* interface_name,
- MessageFilter* request_validator,
+ std::unique_ptr<MessageReceiver> request_validator,
bool has_sync_methods,
MessageReceiverWithResponderStatus* stub) {
- internal::FilterChain filters;
+ FilterChain filters;
filters.Append<MessageHeaderValidator>(interface_name);
- filters.Append(request_validator);
+ filters.Append(std::move(request_validator));
router_ = new internal::Router(std::move(handle), std::move(filters),
has_sync_methods, std::move(runner));
@@ -111,7 +116,7 @@ void MultiplexedBindingState::BindInternal(
ScopedMessagePipeHandle handle,
scoped_refptr<base::SingleThreadTaskRunner> runner,
const char* interface_name,
- std::unique_ptr<MessageFilter> request_validator,
+ std::unique_ptr<MessageReceiver> request_validator,
bool has_sync_methods,
MessageReceiverWithResponderStatus* stub) {
DCHECK(!router_);
« no previous file with comments | « mojo/public/cpp/bindings/lib/binding_state.h ('k') | mojo/public/cpp/bindings/lib/filter_chain.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698