content/renderer/media/webmediaplayer_ms.cc - Issue 2276033002: Pass SkPaint instead of its alpha and mode in WebMediaPlayer::paint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webmediaplayer_ms.cc

Issue 2276033002: Pass SkPaint instead of its alpha and mode in WebMediaPlayer::paint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: better naming Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/html_video_element_capturer_source.cc ('K') | « content/renderer/media/webmediaplayer_ms.h ('k') | media/blink/webmediaplayer_impl.h » ('j') | media/renderers/skcanvas_video_renderer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webmediaplayer_ms.cc

diff --git a/content/renderer/media/webmediaplayer_ms.cc b/content/renderer/media/webmediaplayer_ms.cc

index 9a16a945d4c66aee7cecb37fc48de71b423daf71..fbab310c4607073141c18861beee8861369ebfd3 100644

--- a/content/renderer/media/webmediaplayer_ms.cc

+++ b/content/renderer/media/webmediaplayer_ms.cc

@@ -332,8 +332,7 @@ bool WebMediaPlayerMS::didLoadingProgress() {

void WebMediaPlayerMS::paint(blink::WebCanvas* canvas,

const blink::WebRect& rect,

- unsigned char alpha,

- SkXfermode::Mode mode) {

+ SkPaint& paint) {

DVLOG(3) << __func__;

DCHECK(thread_checker_.CalledOnValidThread());

@@ -351,7 +350,7 @@ void WebMediaPlayerMS::paint(blink::WebCanvas* canvas,

DCHECK(context_3d.gl);

}

const gfx::RectF dest_rect(rect.x, rect.y, rect.width, rect.height);

- video_renderer_.Paint(frame, canvas, dest_rect, alpha, mode,

+ video_renderer_.Paint(frame, canvas, dest_rect, paint,

video_rotation_, context_3d);

}