Pass SkPaint instead of its alpha and mode in WebMediaPlayer::paint

content/renderer/media/html_video_element_capturer_source.cc

Index: content/renderer/media/html_video_element_capturer_source.cc
diff --git a/content/renderer/media/html_video_element_capturer_source.cc b/content/renderer/media/html_video_element_capturer_source.cc
index 738f741157f10cb685c148a3573daac06f044401..b95a0677387fd75d74711a063bca0b88818093d8 100644
--- a/content/renderer/media/html_video_element_capturer_source.cc
+++ b/content/renderer/media/html_video_element_capturer_source.cc
@@ -135,9 +135,12 @@ void HtmlVideoElementCapturerSource::sendNewFrame() {
   const blink::WebSize resolution = web_media_player_->naturalSize();
 
   SkCanvas* canvas = surface_->getCanvas();
+  SkPaint paint;
+  paint.setXfermodeMode(SkXfermode::kSrc_Mode);
+  paint.setFilterQuality(kLow_SkFilterQuality);

[chcunningham, 2016/09/06 23:07:33]

Are you missing a call to setAlpha(0xFF)? Does this line replace that call?

[xidachen, 2016/09/07 13:23:07]

The 0xFF is by default when the SkPaint is defined. As you can see in this line:
https://cs.chromium.org/chromium/src/third_party/skia/src/core/SkPaint.cpp?sq...

   web_media_player_->paint(
       canvas, blink::WebRect(0, 0, resolution.width, resolution.height),
-      0xFF /* alpha */, SkXfermode::kSrc_Mode);
+      paint);
   DCHECK_NE(kUnknown_SkColorType, canvas->imageInfo().colorType());
   DCHECK_EQ(canvas->imageInfo().width(), resolution.width);
   DCHECK_EQ(canvas->imageInfo().height(), resolution.height);