Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2275973002: [arm] Fix an accessor return type. (Closed)

Created:
4 years, 4 months ago by jbramley
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Fix an accessor return type. Existing uses are correct but the return type was misleading. Also clarify some related comments to make the difference between Bits and BitField more obvious. BUG= Committed: https://crrev.com/a338dad442e4a22c8d8f53e6351d2fb640fbbfb2 Cr-Commit-Position: refs/heads/master@{#38894}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M src/arm/constants-arm.h View 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jbramley
4 years, 4 months ago (2016-08-24 12:46:41 UTC) #2
Benedikt Meurer
lgtm
4 years, 4 months ago (2016-08-24 17:40:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275973002/1
4 years, 4 months ago (2016-08-25 08:41:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-25 09:05:08 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 09:05:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a338dad442e4a22c8d8f53e6351d2fb640fbbfb2
Cr-Commit-Position: refs/heads/master@{#38894}

Powered by Google App Engine
This is Rietveld 408576698