Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: src/arm/constants-arm.h

Issue 2275973002: [arm] Fix an accessor return type. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm/constants-arm.h
diff --git a/src/arm/constants-arm.h b/src/arm/constants-arm.h
index a1620516a2f6d4b0070d2ea01944f3bc4063e92d..2bade20fedf5979475bc7d36ea1ba8f7a10c8095 100644
--- a/src/arm/constants-arm.h
+++ b/src/arm/constants-arm.h
@@ -477,40 +477,42 @@ class Instruction {
*reinterpret_cast<Instr*>(this) = value;
}
- // Read one particular bit out of the instruction bits.
+ // Extract a single bit from the instruction bits and return it as bit 0 in
+ // the result.
inline int Bit(int nr) const {
return (InstructionBits() >> nr) & 1;
}
- // Read a bit field's value out of the instruction bits.
+ // Extract a bit field <hi:lo> from the instruction bits and return it in the
+ // least-significant bits of the result.
inline int Bits(int hi, int lo) const {
return (InstructionBits() >> lo) & ((2 << (hi - lo)) - 1);
}
- // Read a bit field out of the instruction bits.
+ // Read a bit field <hi:lo>, leaving its position unchanged in the result.
inline int BitField(int hi, int lo) const {
return InstructionBits() & (((2 << (hi - lo)) - 1) << lo);
}
// Static support.
- // Read one particular bit out of the instruction bits.
+ // Extract a single bit from the instruction bits and return it as bit 0 in
+ // the result.
static inline int Bit(Instr instr, int nr) {
return (instr >> nr) & 1;
}
- // Read the value of a bit field out of the instruction bits.
+ // Extract a bit field <hi:lo> from the instruction bits and return it in the
+ // least-significant bits of the result.
static inline int Bits(Instr instr, int hi, int lo) {
return (instr >> lo) & ((2 << (hi - lo)) - 1);
}
-
- // Read a bit field out of the instruction bits.
+ // Read a bit field <hi:lo>, leaving its position unchanged in the result.
static inline int BitField(Instr instr, int hi, int lo) {
return instr & (((2 << (hi - lo)) - 1) << lo);
}
-
// Accessors for the different named fields used in the ARM encoding.
// The naming of these accessor corresponds to figure A3-1.
//
@@ -525,13 +527,11 @@ class Instruction {
// Generally applicable fields
- inline Condition ConditionValue() const {
- return static_cast<Condition>(Bits(31, 28));
- }
+ inline int ConditionValue() const { return Bits(31, 28); }
inline Condition ConditionField() const {
return static_cast<Condition>(BitField(31, 28));
}
- DECLARE_STATIC_TYPED_ACCESSOR(Condition, ConditionValue);
+ DECLARE_STATIC_TYPED_ACCESSOR(int, ConditionValue);
DECLARE_STATIC_TYPED_ACCESSOR(Condition, ConditionField);
inline int TypeValue() const { return Bits(27, 25); }
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698