[modules] Minor refactorings in scopes and scopeinfos.

[modules] Minor refactorings in scopes and scopeinfos.

R=adamk@chromium.org
BUG=v8:1569
Committed: https://crrev.com/04d81120368173ee91fab193f8cd0837d9628dd4
Cr-Commit-Position: refs/heads/master@{#38931}

[neis, 2016-08-25 14:00:25]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 14:00:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[neis, 2016-08-25 14:00:36]

Description was changed from

==========
[modules] Minor refactorings in scopes and scopeinfos.

R=adamk@chromium.org
BUG=
==========

to

==========
[modules] Minor refactorings in scopes and scopeinfos.

R=adamk@chromium.org
BUG=v8:1569
==========

[neis, 2016-08-25 14:00:43]

ptal

[commit-bot: I haz the power, 2016-08-25 14:34:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 14:34:33]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-08-25 16:04:09]

lgtm (though I don't have owners for everything) except for one question

https://codereview.chromium.org/2275943005/diff/1/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2275943005/diff/1/src/ast/scopes.cc#newcode614
src/ast/scopes.cc:614: !IsLexicalVariableMode(mode)));
You should actually be able to tighten this one more bit: mode == VAR (no
CONST_LEGACY globals)

https://codereview.chromium.org/2275943005/diff/1/src/ast/scopes.cc#newcode617
src/ast/scopes.cc:617: location = VariableLocation::LOOKUP;
Why did this move out of the "found a parameter" block?

[neis, 2016-08-26 07:30:21]

On 2016/08/25 16:04:09, adamk wrote:
> lgtm (though I don't have owners for everything) except for one question
> 
> https://codereview.chromium.org/2275943005/diff/1/src/ast/scopes.cc
> File src/ast/scopes.cc (right):
> 
> https://codereview.chromium.org/2275943005/diff/1/src/ast/scopes.cc#newcode614
> src/ast/scopes.cc:614: !IsLexicalVariableMode(mode)));
> You should actually be able to tighten this one more bit: mode == VAR (no
> CONST_LEGACY globals)
> 
> https://codereview.chromium.org/2275943005/diff/1/src/ast/scopes.cc#newcode617
> src/ast/scopes.cc:617: location = VariableLocation::LOOKUP;
> Why did this move out of the "found a parameter" block?

That's only for symmetry to the other three cases.

[neis, 2016-08-26 07:31:08]

> >
https://codereview.chromium.org/2275943005/diff/1/src/ast/scopes.cc#newcode614
> > src/ast/scopes.cc:614: !IsLexicalVariableMode(mode)));
> > You should actually be able to tighten this one more bit: mode == VAR (no
> > CONST_LEGACY globals)

Done.

[neis, 2016-08-26 07:32:29]

neis@chromium.org changed reviewers:
+ bmeurer@chromium.org

[neis, 2016-08-26 07:32:44]

Benedikt, PTAL

[Benedikt Meurer, 2016-08-26 07:47:48]

lgtm

[neis, 2016-08-26 07:58:46]

The CQ bit was checked by neis@chromium.org

[neis, 2016-08-26 07:58:47]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org,
bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2275943005/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-08-26 07:58:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 08:31:02]

Description was changed from

==========
[modules] Minor refactorings in scopes and scopeinfos.

R=adamk@chromium.org
BUG=v8:1569
==========

to

==========
[modules] Minor refactorings in scopes and scopeinfos.

R=adamk@chromium.org
BUG=v8:1569
==========

[commit-bot: I haz the power, 2016-08-26 08:31:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-26 08:31:18]

Description was changed from

==========
[modules] Minor refactorings in scopes and scopeinfos.

R=adamk@chromium.org
BUG=v8:1569
==========

to

==========
[modules] Minor refactorings in scopes and scopeinfos.

R=adamk@chromium.org
BUG=v8:1569

Committed: https://crrev.com/04d81120368173ee91fab193f8cd0837d9628dd4
Cr-Commit-Position: refs/heads/master@{#38931}
==========

[commit-bot: I haz the power, 2016-08-26 08:31:19]

Patchset 3 (id:??) landed as
https://crrev.com/04d81120368173ee91fab193f8cd0837d9628dd4
Cr-Commit-Position: refs/heads/master@{#38931}