src/crankshaft/typing.cc - Issue 2275943005: [modules] Minor refactorings in scopes and scopeinfos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/typing.cc

Issue 2275943005: [modules] Minor refactorings in scopes and scopeinfos. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@modules-serialize-entry

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/crankshaft/typing.cc

diff --git a/src/crankshaft/typing.cc b/src/crankshaft/typing.cc

index 596183871101711cd27a7b333b254940cc2694a0..d4854acd42053685a58c9bc7e31c5fb94dce499c 100644

--- a/src/crankshaft/typing.cc

+++ b/src/crankshaft/typing.cc

@@ -87,8 +87,7 @@ void AstTyper::ObserveTypesAtOsrEntry(IterationStatement* stmt) {

ZoneList<Variable*> local_vars(locals, zone());

ZoneList<Variable*> context_vars(scope_->ContextLocalCount(), zone());

ZoneList<Variable*> global_vars(scope_->ContextGlobalCount(), zone());

- scope_->CollectStackAndContextLocals(&local_vars, &context_vars,

- &global_vars);

+ scope_->CollectVariables(&local_vars, &context_vars, &global_vars);

for (int i = 0; i < locals; i++) {

PrintObserved(local_vars.at(i),

frame->GetExpression(i),

« no previous file with comments | « src/ast/scopes.cc ('k') | src/debug/liveedit.cc » ('j') | no next file with comments »