Modifies the threshold for hidpi displays.

Modifies the threshold for hidpi displays.

It is really tough to use some 4K monitor from ChromeOS because
the resolution is too high in comparison with the physical size.

Better to use 2X mode in such case.

BUG=348279
R=oshima@chromium.org
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262922

[Jun Mukai, 2014-04-08 19:30:49]

ping?

[oshima, 2014-04-08 20:39:46]

still reviewing the rest.

https://codereview.chromium.org/227593011/diff/1/ash/display/display_change_o...
File ash/display/display_change_observer_chromeos.cc (right):

https://codereview.chromium.org/227593011/diff/1/ash/display/display_change_o...
ash/display/display_change_observer_chromeos.cc:37: // The HiDPI threshold for
bigger (usually external) monitors. Lower threshold
"Large" is probably better term. Can you update the one above to XxxSmall ?

https://codereview.chromium.org/227593011/diff/1/ash/display/display_change_o...
ash/display/display_change_observer_chromeos.cc:59: bool ShouldBeHiDPI(const
gfx::Size& physical_size,
Can you change this to return scale factor (like GetScaleFactor(...))
and write unit tests?

[oshima, 2014-04-08 23:07:42]

as discussed offline, we should include scale factor as the scale factor changes
depending on the resolution a user selects on external displays.

https://codereview.chromium.org/227593011/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
(right):

https://codereview.chromium.org/227593011/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/chromeos/display_options_handler.cc:271:
gfx::Size current_size = display_info.bounds_in_native().size();
would you mind refacotring this define a method that creates the resoulution
info for internal/external display?

[Jun Mukai, 2014-04-09 20:20:06]

https://codereview.chromium.org/227593011/diff/1/ash/display/display_change_o...
File ash/display/display_change_observer_chromeos.cc (right):

https://codereview.chromium.org/227593011/diff/1/ash/display/display_change_o...
ash/display/display_change_observer_chromeos.cc:37: // The HiDPI threshold for
bigger (usually external) monitors. Lower threshold
On 2014/04/08 20:39:47, oshima wrote:
> "Large" is probably better term. Can you update the one above to XxxSmall ?

Done.

https://codereview.chromium.org/227593011/diff/1/ash/display/display_change_o...
ash/display/display_change_observer_chromeos.cc:59: bool ShouldBeHiDPI(const
gfx::Size& physical_size,
On 2014/04/08 20:39:47, oshima wrote:
> Can you change this to return scale factor (like GetScaleFactor(...))
> and write unit tests?

Done.

https://codereview.chromium.org/227593011/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
(right):

https://codereview.chromium.org/227593011/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/chromeos/display_options_handler.cc:271:
gfx::Size current_size = display_info.bounds_in_native().size();
On 2014/04/08 23:07:43, oshima wrote:
> would you mind refacotring this define a method that creates the resoulution
> info for internal/external display?

Done.

[oshima, 2014-04-09 23:07:37]

https://codereview.chromium.org/227593011/diff/20001/ash/display/display_chan...
File ash/display/display_change_observer_chromeos.cc (right):

https://codereview.chromium.org/227593011/diff/20001/ash/display/display_chan...
ash/display/display_change_observer_chromeos.cc:100: float
DisplayChangeObserver::GetScaleFactor(
can you move this (plus constants) to ui/display/display_util.h ?

https://codereview.chromium.org/227593011/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
(right):

https://codereview.chromium.org/227593011/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/chromeos/display_options_handler.cc:61: int w1 =
0, h1 = 0, w2 = 0, h2 = 0;
width1/height1

[Jun Mukai, 2014-04-09 23:16:00]

https://codereview.chromium.org/227593011/diff/20001/ash/display/display_chan...
File ash/display/display_change_observer_chromeos.cc (right):

https://codereview.chromium.org/227593011/diff/20001/ash/display/display_chan...
ash/display/display_change_observer_chromeos.cc:100: float
DisplayChangeObserver::GetScaleFactor(
On 2014/04/09 23:07:37, oshima wrote:
> can you move this (plus constants) to ui/display/display_util.h ?

Done.

https://codereview.chromium.org/227593011/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
(right):

https://codereview.chromium.org/227593011/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/chromeos/display_options_handler.cc:61: int w1 =
0, h1 = 0, w2 = 0, h2 = 0;
On 2014/04/09 23:07:37, oshima wrote:
> width1/height1

Done.

[oshima, 2014-04-09 23:35:29]

lgtm with nits

https://codereview.chromium.org/227593011/diff/60001/ui/display/display_util.h
File ui/display/display_util.h (right):

https://codereview.chromium.org/227593011/diff/60001/ui/display/display_util....
ui/display/display_util.h:17: // Returns the device scale factor for the
specific monitor and mode.
// Returns the desired device scale factor for the display with the given
physical_size and resoultion.

https://codereview.chromium.org/227593011/diff/60001/ui/display/display_util....
ui/display/display_util.h:19: const gfx::Size& physical_size,
physical_size_in_mm

https://codereview.chromium.org/227593011/diff/60001/ui/display/display_util....
ui/display/display_util.h:20: const gfx::Size& screen_size);
screen_size_in_pixels

[Jun Mukai, 2014-04-09 23:50:17]

https://codereview.chromium.org/227593011/diff/60001/ui/display/display_util.h
File ui/display/display_util.h (right):

https://codereview.chromium.org/227593011/diff/60001/ui/display/display_util....
ui/display/display_util.h:17: // Returns the device scale factor for the
specific monitor and mode.
On 2014/04/09 23:35:29, oshima wrote:
> // Returns the desired device scale factor for the display with the given
> physical_size and resoultion.

Done.

https://codereview.chromium.org/227593011/diff/60001/ui/display/display_util....
ui/display/display_util.h:19: const gfx::Size& physical_size,
On 2014/04/09 23:35:29, oshima wrote:
> physical_size_in_mm

Done.

https://codereview.chromium.org/227593011/diff/60001/ui/display/display_util....
ui/display/display_util.h:20: const gfx::Size& screen_size);
On 2014/04/09 23:35:29, oshima wrote:
> screen_size_in_pixels

Done.

[Jun Mukai, 2014-04-09 23:50:21]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-04-09 23:50:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/227593011/80001

[commit-bot: I haz the power, 2014-04-10 02:57:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-10 02:57:49]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Jun Mukai, 2014-04-10 03:02:25]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-04-10 03:02:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/227593011/80001

[commit-bot: I haz the power, 2014-04-10 05:07:41]

Change committed as 262922