Test the media element activation behavior in fullscreen

Test the media element activation behavior in fullscreen

BUG=358675
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171372

[philipj_slow, 2014-04-07 15:35:15]

Adding a test for a case I didn't consider when implementing the activation
behavior, and which is causing some trouble. Probably the test will need to be
modified to match a fix for issue 358675, but either way it's nice to have it
tested.

[acolwell GONE FROM CHROMIUM, 2014-04-11 17:44:54]

https://codereview.chromium.org/227593006/diff/1/LayoutTests/media/activation...
File LayoutTests/media/activation-behavior-fullscreen.html (right):

https://codereview.chromium.org/227593006/diff/1/LayoutTests/media/activation...
LayoutTests/media/activation-behavior-fullscreen.html:21:
eventSender.mouseDown();
Why are these mouse events needed? Why are they needed for the first .click()
and not the second one?

https://codereview.chromium.org/227593006/diff/1/LayoutTests/media/activation...
LayoutTests/media/activation-behavior-fullscreen.html:27: requestFullscreen();
nit: Inline here since this doesn't actually appear to request full screen and
it is only used once? Otherwise perhaps use a different function name since this
method seems to be more about setup then actually making a fullscreen request.

[philipj_slow, 2014-04-11 20:49:44]

https://codereview.chromium.org/227593006/diff/1/LayoutTests/media/activation...
File LayoutTests/media/activation-behavior-fullscreen.html (right):

https://codereview.chromium.org/227593006/diff/1/LayoutTests/media/activation...
LayoutTests/media/activation-behavior-fullscreen.html:21:
eventSender.mouseDown();
On 2014/04/11 17:44:55, acolwell wrote:
> Why are these mouse events needed? Why are they needed for the first .click()
> and not the second one?

webkitRequestFullscreen fails unless it's called from a user gesture, but the
default activation behavior has no such restrictions.

https://codereview.chromium.org/227593006/diff/1/LayoutTests/media/activation...
LayoutTests/media/activation-behavior-fullscreen.html:27: requestFullscreen();
On 2014/04/11 17:44:55, acolwell wrote:
> nit: Inline here since this doesn't actually appear to request full screen and
> it is only used once? Otherwise perhaps use a different function name since
this
> method seems to be more about setup then actually making a fullscreen request.

requestFullscreen does request fullscreen by clicking the video. The v.click()
and assert that follows is actually a negative test, since I first suspected
that HTMLMediaElement::isFullscreen() would return true before actually entering
fullscreen. I'll simplify the test a bit.

[acolwell GONE FROM CHROMIUM, 2014-04-11 21:11:18]

lgtm

[philipj_slow, 2014-04-11 21:23:32]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2014-04-11 21:23:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/227593006/40001

[commit-bot: I haz the power, 2014-04-11 21:58:06]

Change committed as 171372