LayoutTests/media/activation-behavior-fullscreen.html - Issue 227593006: Test the media element activation behavior in fullscreen

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/activation-behavior-fullscreen.html

Issue 227593006: Test the media element activation behavior in fullscreen (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <title>activation behavior in fullscreen</title>

	3 <script src="../resources/testharness.js"></script>

	4 <script src="../resources/testharnessreport.js"></script>

	5 <script src="media-file.js"></script>

	6 <div id="log"></div>

	7 <video></video>

	8 <script>

	9 async_test(function(t)

	10 {

	11 var v = document.querySelector("video");

	12 v.src = findMediaFile("video", "content/test");

	13

	14 function requestFullscreen()

	15 {

	16 document.onclick = function()

	17 {

	18 document.onclick = null;

	19 v.webkitRequestFullScreen();

	20 };

	21 eventSender.mouseDown();
	acolwell GONE FROM CHROMIUM 2014/04/11 17:44:55 Why are these mouse events needed? Why are they ne Why are these mouse events needed? Why are they needed for the first .click() and not the second one? philipj_slow 2014/04/11 20:49:44 webkitRequestFullscreen fails unless it's called f Show quoted text On 2014/04/11 17:44:55, acolwell wrote: > Why are these mouse events needed? Why are they needed for the first .click() > and not the second one? webkitRequestFullscreen fails unless it's called from a user gesture, but the default activation behavior has no such restrictions.
	22 eventSender.mouseUp();

	23 }

	24

	25 v.addEventListener("loadeddata", function()

	26 {

	27 requestFullscreen();
	acolwell GONE FROM CHROMIUM 2014/04/11 17:44:55 nit: Inline here since this doesn't actually appea nit: Inline here since this doesn't actually appear to request full screen and it is only used once? Otherwise perhaps use a different function name since this method seems to be more about setup then actually making a fullscreen request. philipj_slow 2014/04/11 20:49:44 requestFullscreen does request fullscreen by click Show quoted text On 2014/04/11 17:44:55, acolwell wrote: > nit: Inline here since this doesn't actually appear to request full screen and > it is only used once? Otherwise perhaps use a different function name since this > method seems to be more about setup then actually making a fullscreen request. requestFullscreen does request fullscreen by clicking the video. The v.click() and assert that follows is actually a negative test, since I first suspected that HTMLMediaElement::isFullscreen() would return true before actually entering fullscreen. I'll simplify the test a bit.
	28 v.click();

	29 assert_true(v.paused, "paused state after click before fullscreen");

	30 });

	31

	32 v.addEventListener("webkitfullscreenchange", function()

	33 {

	34 assert_true(v.paused, "paused state before click in fullscreen");

	35 v.click();

	36 assert_false(v.paused, "paused state after click in fullscreen");

	37 t.done();

	38 });

	39 });

	40 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/media/activation-behavior-fullscreen-expected.txt » ('j') | no next file with comments »