Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2275863002: [devil] Use /data/local/tmp for the command line on eng + userdebug builds. (Closed)

Created:
4 years, 4 months ago by jbudorick
Modified:
4 years, 4 months ago
CC:
catapult-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : prereview: remove leftover pdb.set_trace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M devil/devil/android/flag_changer.py View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jbudorick
4 years, 4 months ago (2016-08-24 03:35:46 UTC) #2
rnephew (Reviews Here)
On 2016/08/24 03:35:46, jbudorick wrote: lgtm
4 years, 4 months ago (2016-08-24 04:43:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275863002/20001
4 years, 4 months ago (2016-08-24 12:59:29 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/ae022b60c580ffbba455d620aab295372ac5ab0d
4 years, 4 months ago (2016-08-24 13:20:25 UTC) #7
perezju
4 years, 3 months ago (2016-08-31 12:33:03 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2296943003/ by perezju@chromium.org.

The reason for reverting is: Broke telemetry tests still using the old command
line path.

Powered by Google App Engine
This is Rietveld 408576698