android: Use /data/local/tmp/ for the command line on userdebug and eng builds.

android: Use /data/local/tmp/ for the command line on userdebug and eng builds.

Android N SELinux policy doesn't allow reading files in /data/local/
anymore. This makes it harder to pass command line arguments. Check
/data/local/tmp on debuggable builds, since this is still readable on
Android N.

BUG=593720
Committed: https://crrev.com/486b0ddbd566364b5d196510a4abe51b4293cdab
Cr-Commit-Position: refs/heads/master@{#406287}

[Benoit L, 2016-07-19 13:58:09]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 13:58:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 14:45:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 14:45:54]

Dry run: This issue passed the CQ dry run.

[Benoit L, 2016-07-19 15:01:03]

lizeb@chromium.org changed reviewers:
+ torne@chromium.org

[Benoit L, 2016-07-19 15:01:23]

On 2016/07/19 15:01:04, Benoit L wrote:

Note: I tested it on a userdebug N phone, it works.

[Torne, 2016-07-19 15:17:56]

This means the existing scripts will immediately break - do we maybe want to
check both locations for now?

[Benoit L, 2016-07-19 15:45:09]

On 2016/07/19 15:17:56, Torne wrote:
> This means the existing scripts will immediately break - do we maybe want to
> check both locations for now?

This means that /data/local/tmp/chrome-command-line has higher priority than
/data/local/chrome-command-line on debug devices. This still checks
/data/local/chrome-command-line if the first one doesn't exist.

Do you have a different behavior in mind?

[Torne, 2016-07-19 15:59:09]

Oh, sorry, I didn't notice that it checks for the file existing first; I thought
it decided the path first and only looked at one of them. LGTM.

[Benoit L, 2016-07-19 16:00:15]

The CQ bit was checked by lizeb@chromium.org

[commit-bot: I haz the power, 2016-07-19 16:00:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 16:05:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-19 16:05:20]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 16:07:33]

Description was changed from

==========
android: Use /data/local/tmp/ for the command line on userdebug and eng builds.

Android N SELinux policy doesn't allow reading files in /data/local/
anymore. This makes it harder to pass command line arguments. Check
/data/local/tmp on debuggable builds, since this is still readable on
Android N.

BUG=593720
==========

to

==========
android: Use /data/local/tmp/ for the command line on userdebug and eng builds.

Android N SELinux policy doesn't allow reading files in /data/local/
anymore. This makes it harder to pass command line arguments. Check
/data/local/tmp on debuggable builds, since this is still readable on
Android N.

BUG=593720

Committed: https://crrev.com/486b0ddbd566364b5d196510a4abe51b4293cdab
Cr-Commit-Position: refs/heads/master@{#406287}
==========

[commit-bot: I haz the power, 2016-07-19 16:07:34]

Patchset 1 (id:??) landed as
https://crrev.com/486b0ddbd566364b5d196510a4abe51b4293cdab
Cr-Commit-Position: refs/heads/master@{#406287}