Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2275753002: Font size should be specified as a percentage. (Closed)

Created:
4 years, 3 months ago by hcarmona
Modified:
4 years, 3 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@darker-search-passwords.gitbr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Font size should be specified as a percentage. BUG=NONE CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f57cd13dbd1079b3f0119124f02dbc06193ec56b Cr-Commit-Position: refs/heads/master@{#414155}

Patch Set 1 #

Patch Set 2 : 100% -> inherit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/settings_page/settings_subpage_search.html View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (11 generated)
hcarmona
PTAL, this is a followup to the previous CL.
4 years, 3 months ago (2016-08-23 21:20:40 UTC) #5
dschuyler
lgtm
4 years, 3 months ago (2016-08-23 21:46:34 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 2272463002 Patch 20001). Please resolve the dependency and ...
4 years, 3 months ago (2016-08-23 22:06:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275753002/20001
4 years, 3 months ago (2016-08-24 18:24:33 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-24 21:43:56 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-08-24 21:47:09 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f57cd13dbd1079b3f0119124f02dbc06193ec56b
Cr-Commit-Position: refs/heads/master@{#414155}

Powered by Google App Engine
This is Rietveld 408576698