Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2272463002:
Change the subpage search text color to --paper-gray-800. (Closed)
|
Created:
4 years, 4 months ago by hcarmona Modified:
4 years, 4 months ago Reviewers:
dschuyler CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionChange the subpage search text color to --paper-gray-800.
Screenshots in bug.
BUG=632591
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/69f435b4d3495f9cb060df79d335393fc5f5cf8a
Cr-Commit-Position: refs/heads/master@{#413861}
Patch Set 1 #
Total comments: 4
Patch Set 2 : feedback #
Dependent Patchsets: Messages
Total messages: 18 (11 generated)
Description was changed from ========== Change the subpage search text color to --paper-gray-800. Screenshots in bug. BUG=632591 ========== to ========== Change the subpage search text color to --paper-gray-800. Screenshots in bug. BUG=632591 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
hcarmona@chromium.org changed reviewers: + dschuyler@chromium.org
PTAL, different shade of grey for search text.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2272463002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_page/settings_subpage_search.html (right): https://codereview.chromium.org/2272463002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_page/settings_subpage_search.html:25: font-size: 13px; This can be done in this CL or a separate CL: the font-size should be expressed as a percentage of the inherited font size. E.g. https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/settin... https://codereview.chromium.org/2272463002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_page/settings_subpage_search.html:27: } Let's make a #prompt with just a color, a #searchInput with just a color, and then a third block for #prompt, #searchInput { with the font-size/height }
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2272463002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_page/settings_subpage_search.html (right): https://codereview.chromium.org/2272463002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_page/settings_subpage_search.html:25: font-size: 13px; On 2016/08/23 02:17:26, dschuyler wrote: > This can be done in this CL or a separate CL: the font-size should be > expressed as a percentage of the inherited font size. > > E.g. > https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/settin... Sounds good, I'll create a followup CL for this. https://codereview.chromium.org/2272463002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_page/settings_subpage_search.html:27: } On 2016/08/23 02:17:26, dschuyler wrote: > Let's make a #prompt with just a color, a #searchInput with just a color, and > then a third block for > #prompt, > #searchInput { > with the font-size/height > } Done.
lgtm
The CQ bit was unchecked by hcarmona@chromium.org
The CQ bit was checked by hcarmona@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Change the subpage search text color to --paper-gray-800. Screenshots in bug. BUG=632591 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Change the subpage search text color to --paper-gray-800. Screenshots in bug. BUG=632591 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/69f435b4d3495f9cb060df79d335393fc5f5cf8a Cr-Commit-Position: refs/heads/master@{#413861} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/69f435b4d3495f9cb060df79d335393fc5f5cf8a Cr-Commit-Position: refs/heads/master@{#413861} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
