chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java - Issue 2275693003: Ntp: show footer with learn more link.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java

Issue 2275693003: Ntp: show footer with learn more link. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@9patches

Patch Set: Use the intended url. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java ('k') | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java

index 410ca3ab83d764264cf122fe84467d72dbce7adb..574b286e582135c346f562f6245e28695b47cfa9 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java

@@ -23,7 +23,6 @@ public class SectionHeaderViewHolder extends NewTabPageViewHolder {

private final int mMaxSnippetHeaderHeight;

private final int mMaxPeekPadding;

- private final TextView mHeaderTextView;

private final NewTabPageRecyclerView mRecyclerView;

private SectionHeader mHeaderListItem;

@@ -37,7 +36,6 @@ public class SectionHeaderViewHolder extends NewTabPageViewHolder {

mMaxPeekPadding = itemView.getResources().getDimensionPixelSize(

R.dimen.snippets_padding_and_peeking_card_height);

- mHeaderTextView = (TextView) itemView.findViewById(R.id.suggestions_section_header);

mRecyclerView = recyclerView;

MarginResizer.createWithViewAdapter(itemView, config);

}

@@ -45,7 +43,7 @@ public class SectionHeaderViewHolder extends NewTabPageViewHolder {

@Override

public void onBindViewHolder(NewTabPageItem header) {

mHeaderListItem = (SectionHeader) header;

- mHeaderTextView.setText(mHeaderListItem.getHeaderText());

+ ((TextView) itemView).setText(mHeaderListItem.getHeaderText());

updateDisplay(0, false);

}