Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

Issue 2275693003: Ntp: show footer with learn more link. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@9patches
Patch Set: Use the intended url. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
index ea9d3b60b14dd79485828d0552d24ea906375185..66e6da3681d9b53bc87209dd1bb2a28fc665a302 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
@@ -246,7 +246,7 @@ public class NewTabPageRecyclerView extends RecyclerView {
/**
* Finds the view holder for the first header.
- * @return The {@link ViewHolder} of the header, or null if it is not present.
+ * @return The {@code ViewHolder} of the header, or null if it is not present.
*/
private SectionHeaderViewHolder findFirstHeader() {
ViewHolder viewHolder =
@@ -258,7 +258,7 @@ public class NewTabPageRecyclerView extends RecyclerView {
/**
* Finds the view holder for the first card.
- * @return The {@link ViewHolder} for the first card, or null if it is not present.
+ * @return The {@code ViewHolder} for the first card, or null if it is not present.
*/
private CardViewHolder findFirstCard() {
ViewHolder viewHolder =
@@ -269,21 +269,20 @@ public class NewTabPageRecyclerView extends RecyclerView {
}
/**
- * Finds the view holder for the last content item: a card or status indicator.
- * @return The {@link ViewHolder} of the last content item, or null if it is not present.
+ * Finds the view holder for the last content item: the footer.
+ * @return The {@code ViewHolder} of the last content item, or null if it is not present.
*/
private ViewHolder findLastContentItem() {
ViewHolder viewHolder = findViewHolderForAdapterPosition(
getNewTabPageAdapter().getLastContentItemPosition());
- if (viewHolder instanceof CardViewHolder) return viewHolder;
- if (viewHolder instanceof ProgressViewHolder) return viewHolder;
+ if (viewHolder instanceof Footer.ViewHolder) return viewHolder;
return null;
}
/**
* Finds the view holder for the bottom spacer.
- * @return The {@link ViewHolder} of the bottom spacer, or null if it is not present.
+ * @return The {@code ViewHolder} of the bottom spacer, or null if it is not present.
*/
private ViewHolder findBottomSpacer() {
return findViewHolderForAdapterPosition(getNewTabPageAdapter().getBottomSpacerPosition());

Powered by Google App Engine
This is Rietveld 408576698