Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2275643004: Make android recipes explicitly set GIT_MODE (Closed)

Created:
4 years, 4 months ago by agable
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Catch dartium android builders #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2589 lines, -1272 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 1 chunk +3 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/basic_builder_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/coverage_builder_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/device_file_format_mismatch.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/device_flags_builder_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/downgrade_install_tester_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/enable_platform_mode_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/gerrit_refs.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/gerrit_try_builder_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/java_method_count_builder_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/json_results_file_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/last_known_devices_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/no_cache_builder_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/no_strict_mode_tester_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_adb_vendor_keys_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_allow_high_battery_temp_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_allow_low_battery_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_disable_location_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_user_build_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_tests_failure.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_tests_infra_failure.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/resource_size_builder_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/restart_usb_builder_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/result_details_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/slow_tester_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/specific_install_tester_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/telemetry_browser_tests_failures.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/telemetry_browser_tests_tester_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/tester_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/tester_blacklisted_devices.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/tester_no_devices_during_recovery.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/tester_no_devices_during_status.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/tester_offline_devices.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/tester_other_device_failure_during_recovery.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/tester_other_device_failure_during_status.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/tester_with_step_warning.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/timestamp_as_point_id_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/tombstones_m53.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_expected_failure.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_invalid_output.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_invalid_platform.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_unexecuted_tests.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_unexpected_class_failure.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_unexpected_method_failure.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_tester_basic.json View 2 chunks +53 lines, -26 lines 0 comments Download
M scripts/slave/recipes/android/builder.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/builder.expected/chromium_android_Android_x64_Builder__dbg__fail_check_licenses.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_chromium_android_Android_MIPS_Builder__dbg_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_chromium_android_Android_x64_Builder__dbg_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_chromium_android_Android_x86_Builder__dbg_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_chromium_perf_Android_Builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_chromium_perf_Android_arm64_Builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_client_v8_fyi_Android_Builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_tryserver_chromium_perf_android_arm64_perf_bisect_builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_tryserver_chromium_perf_android_perf_bisect_builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Power_Nexus_5X_Perf__1_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/get_perf_test_list_old_data.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/host_info_failure.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/missing_device.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/provision_devices.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/src_side_script_fails.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/test_failure.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/dart/dartium_android_builder.expected/dartium_builder_basic.json View 1 2 chunks +53 lines, -16 lines 0 comments Download
M scripts/slave/recipes/dart/dartium_android_builder.expected/dartium_builder_git.json View 1 2 chunks +53 lines, -16 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
agable
4 years, 4 months ago (2016-08-24 20:50:06 UTC) #1
ghost stip (do not use)
can you explain to me what GIT_MODE means, and when it would be unset?
4 years, 4 months ago (2016-08-24 20:52:15 UTC) #2
agable
On 2016/08/24 at 20:52:15, stip wrote: > can you explain to me what GIT_MODE means, ...
4 years, 4 months ago (2016-08-24 20:56:03 UTC) #3
ghost stip (do not use)
ok. lgtm, I added dtu@ since this affects perf. please get his approval before committing
4 years, 4 months ago (2016-08-24 21:11:42 UTC) #6
dtu
lgtm
4 years, 4 months ago (2016-08-24 21:39:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275643004/20001
4 years, 4 months ago (2016-08-24 21:40:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275643004/20001
4 years, 4 months ago (2016-08-24 22:10:52 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 22:15:59 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/6ae64c302a5ae3bfc0df...

Powered by Google App Engine
This is Rietveld 408576698