Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Side by Side Diff: scripts/slave/recipes/android/builder.py

Issue 2275643004: Make android recipes explicitly set GIT_MODE (Closed)
Patch Set: Catch dartium android builders Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from contextlib import contextmanager 5 from contextlib import contextmanager
6 from recipe_engine import recipe_api 6 from recipe_engine import recipe_api
7 from recipe_engine.types import freeze 7 from recipe_engine.types import freeze
8 8
9 DEPS = [ 9 DEPS = [
10 'chromium', 10 'chromium',
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 'REPO_URL': 'svn://svn-mirror.golo.chromium.org/chrome/trunk/src', 177 'REPO_URL': 'svn://svn-mirror.golo.chromium.org/chrome/trunk/src',
178 'INTERNAL': False, 178 'INTERNAL': False,
179 'REPO_NAME': 'src', 179 'REPO_NAME': 'src',
180 'BUILD_CONFIG': bot_config.get('target', 'Debug'), 180 'BUILD_CONFIG': bot_config.get('target', 'Debug'),
181 } 181 }
182 default_kwargs.update(bot_config.get('kwargs', {})) 182 default_kwargs.update(bot_config.get('kwargs', {}))
183 droid.configure_from_properties(bot_config['recipe_config'], **default_kwargs) 183 droid.configure_from_properties(bot_config['recipe_config'], **default_kwargs)
184 api.chromium.set_config(bot_config['recipe_config'], **default_kwargs) 184 api.chromium.set_config(bot_config['recipe_config'], **default_kwargs)
185 droid.c.set_val({'deps_file': 'DEPS'}) 185 droid.c.set_val({'deps_file': 'DEPS'})
186 186
187 api.gclient.set_config('chromium') 187 api.gclient.set_config('chromium', GIT_MODE=True)
188 for c in bot_config.get('gclient_apply_config', []): 188 for c in bot_config.get('gclient_apply_config', []):
189 api.gclient.apply_config(c) 189 api.gclient.apply_config(c)
190 190
191 if bot_config.get('set_component_rev'): 191 if bot_config.get('set_component_rev'):
192 # If this is a component build and the main revision is e.g. blink, 192 # If this is a component build and the main revision is e.g. blink,
193 # webrtc, or v8, the custom deps revision of this component must be 193 # webrtc, or v8, the custom deps revision of this component must be
194 # dynamically set to either: 194 # dynamically set to either:
195 # (1) 'revision' from the waterfall, or 195 # (1) 'revision' from the waterfall, or
196 # (2) 'HEAD' for forced builds with unspecified 'revision'. 196 # (2) 'HEAD' for forced builds with unspecified 'revision'.
197 component_rev = revision 197 component_rev = revision
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 '_'.join(_sanitize_nonalpha(step) for step in steps))) + 264 '_'.join(_sanitize_nonalpha(step) for step in steps))) +
265 props(mastername=mastername, buildername=buildername) + 265 props(mastername=mastername, buildername=buildername) +
266 reduce(lambda a, b: a + b, 266 reduce(lambda a, b: a + b,
267 (api.step_data(step, retcode=1) for step in steps)) 267 (api.step_data(step, retcode=1) for step in steps))
268 ) 268 )
269 269
270 yield step_failure(mastername='chromium.android', 270 yield step_failure(mastername='chromium.android',
271 buildername='Android x64 Builder (dbg)', 271 buildername='Android x64 Builder (dbg)',
272 steps=['check licenses']) 272 steps=['check licenses'])
273 273
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698