Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2275643003: Notify about PageState changes after an AUTO_SUBFRAME commit. (Closed)

Created:
4 years, 4 months ago by Charlie Reis
Modified:
4 years, 4 months ago
Reviewers:
sky, nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Notify about PageState changes after an AUTO_SUBFRAME commit. The session restore logic (specifically when exiting and restarting) depends on NOTIFICATION_NAV_ENTRY_CHANGED notifications for subframes. In the old navigation logic, this happened for subframes during the first UpdateState after an AUTO_SUBFRAME commit. In the new navigation logic, we have already put the PageState on the FrameNavigationEntry at commit time, so the UpdateState typically looks like a no-op and doesn't generate a notification. To fix this (and get the notification out as early as possible), this CL notifies at commit time for AUTO_SUBFRAMEs. BUG=638088 TEST=Visit chrome://help, then chrome://restart. NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/59d5a47cb75df2754b71732c5581f2bb6be54c9c Cr-Commit-Position: refs/heads/master@{#414207}

Patch Set 1 #

Patch Set 2 : Fix unit test expectations. #

Patch Set 3 : Add test. #

Patch Set 4 : Add test file. #

Patch Set 5 : Clean up. #

Total comments: 2

Patch Set 6 : Switch to ASSERT_TRUE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -6 lines) Patch
M chrome/browser/sessions/session_restore_browsertest.cc View 1 2 3 4 5 1 chunk +38 lines, -0 lines 0 comments Download
A chrome/test/data/iframe_blank.html View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 1 1 chunk +7 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 5 chunks +35 lines, -5 lines 0 comments Download

Messages

Total messages: 34 (25 generated)
Charlie Reis
nasko@, can you review? This is the fix you suggested, sending the notification at commit ...
4 years, 4 months ago (2016-08-24 19:15:07 UTC) #16
sky
LGTM https://codereview.chromium.org/2275643003/diff/80001/chrome/browser/sessions/session_restore_browsertest.cc File chrome/browser/sessions/session_restore_browsertest.cc (right): https://codereview.chromium.org/2275643003/diff/80001/chrome/browser/sessions/session_restore_browsertest.cc#newcode1300 chrome/browser/sessions/session_restore_browsertest.cc:1300: EXPECT_TRUE(content::ExecuteScript( ASSERT_TRUE? Otherwise if it fails the observer ...
4 years, 4 months ago (2016-08-24 20:25:58 UTC) #17
nasko
Thanks for putting this one together. LGTM!
4 years, 4 months ago (2016-08-24 20:30:42 UTC) #18
Charlie Reis
Thanks! https://codereview.chromium.org/2275643003/diff/80001/chrome/browser/sessions/session_restore_browsertest.cc File chrome/browser/sessions/session_restore_browsertest.cc (right): https://codereview.chromium.org/2275643003/diff/80001/chrome/browser/sessions/session_restore_browsertest.cc#newcode1300 chrome/browser/sessions/session_restore_browsertest.cc:1300: EXPECT_TRUE(content::ExecuteScript( On 2016/08/24 20:25:57, sky wrote: > ASSERT_TRUE? ...
4 years, 4 months ago (2016-08-24 20:31:59 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/268067)
4 years, 4 months ago (2016-08-24 23:46:54 UTC) #26
Charlie Reis
On 2016/08/24 23:46:54, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 4 months ago (2016-08-24 23:49:22 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275643003/100001
4 years, 4 months ago (2016-08-24 23:50:43 UTC) #30
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 4 months ago (2016-08-24 23:57:50 UTC) #32
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 00:00:10 UTC) #34
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/59d5a47cb75df2754b71732c5581f2bb6be54c9c
Cr-Commit-Position: refs/heads/master@{#414207}

Powered by Google App Engine
This is Rietveld 408576698