Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1847)

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 2275643003: Notify about PageState changes after an AUTO_SUBFRAME commit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Switch to ASSERT_TRUE. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_controller_impl.cc
diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc
index 124346013c998a5b9e8c63f03feede3a243008a8..93d424befef75bd633975ba0baadf85a9ae28f5f 100644
--- a/content/browser/frame_host/navigation_controller_impl.cc
+++ b/content/browser/frame_host/navigation_controller_impl.cc
@@ -835,8 +835,14 @@ bool NavigationControllerImpl::RendererDidNavigate(
details->did_replace_entry);
break;
case NAVIGATION_TYPE_AUTO_SUBFRAME:
- if (!RendererDidNavigateAutoSubframe(rfh, params))
+ if (!RendererDidNavigateAutoSubframe(rfh, params)) {
+ // In UseSubframeNavigationEntries mode, we won't send a notification
+ // about auto-subframe PageState during UpdateStateForFrame, since it
+ // looks like nothing has changed. Send it here at commit time instead.
+ if (SiteIsolationPolicy::UseSubframeNavigationEntries())
+ NotifyEntryChanged(GetLastCommittedEntry());
return false;
+ }
break;
case NAVIGATION_TYPE_NAV_IGNORE:
// If a pending navigation was in progress, this canceled it. We should
« no previous file with comments | « chrome/test/data/iframe_blank.html ('k') | content/browser/frame_host/navigation_controller_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698