Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2275603003: Make syzygy recipes explicitly set GIT_MODE (Closed)

Created:
4 years, 4 months ago by agable
Modified:
4 years, 4 months ago
Reviewers:
iannucci, chrisha, martiniss
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fixup module calls too #

Patch Set 3 : Also fixup v8 module code #

Patch Set 4 : Add module #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M scripts/slave/recipe_modules/syzygy/example.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/syzygy/example.expected/full_master_client_syzygy_Syzygy_Coverage.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/syzygy/example.expected/full_master_client_syzygy_Syzygy_Debug.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/syzygy/example.expected/full_master_client_syzygy_Syzygy_Official.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/syzygy/continuous.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_Syzygy_Debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_Syzygy_Official.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_Syzygy_Release.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_win8_rel_try.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_win_dbg_try.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_win_official_try.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_win_rel_try.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/syzygy/coverage.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/syzygy/coverage.expected/full_master_client_syzygy_Syzygy_Coverage.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/syzygy/coverage.expected/full_master_client_syzygy_win_cov_try.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/syzygy/kasko_official.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/syzygy/kasko_official.expected/full_master_client_syzygy_Kasko_Official.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/syzygy/smoke_test.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/syzygy/smoke_test.expected/full_master_client_syzygy_Syzygy_Smoke_Test.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
agable
4 years, 4 months ago (2016-08-23 20:21:33 UTC) #1
Nico
I don't know what the change does or why it's being done, nor do I ...
4 years, 4 months ago (2016-08-23 20:23:21 UTC) #3
agable
On 2016/08/23 at 20:23:21, thakis wrote: > I don't know what the change does or ...
4 years, 4 months ago (2016-08-23 20:38:09 UTC) #4
martiniss
lgtm
4 years, 4 months ago (2016-08-24 20:08:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275603003/70001
4 years, 4 months ago (2016-08-24 20:10:17 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 20:15:05 UTC) #11
Message was sent while issue was closed. 
Committed patchset #5 (id:70001) as
https://chromium.googlesource.com/chromium/tools/build/+/38954ea2aea645d40d93...

Powered by Google App Engine
This is Rietveld 408576698