scripts/slave/recipe_modules/syzygy/example.py - Issue 2275603003: Make syzygy recipes explicitly set GIT_MODE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/syzygy/example.py

Issue 2275603003: Make syzygy recipes explicitly set GIT_MODE (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/syzygy/example.expected/full_master_client_syzygy_Syzygy_Coverage.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/syzygy/example.py

diff --git a/scripts/slave/recipe_modules/syzygy/example.py b/scripts/slave/recipe_modules/syzygy/example.py

index bbd789fab6cdb50165928693aff63897c48c05cc..fa3f743cb593f8e3aea2ed26feec6278304a1759 100644

--- a/scripts/slave/recipe_modules/syzygy/example.py

+++ b/scripts/slave/recipe_modules/syzygy/example.py

@@ -26,16 +26,16 @@ def RunSteps(api, buildername):

if buildername == 'Syzygy Debug':

api.syzygy.set_config('syzygy', BUILD_CONFIG='Debug')

api.chromium.set_config('syzygy', BUILD_CONFIG='Debug')

- api.gclient.set_config('syzygy', BUILD_CONFIG='Debug')

+ api.gclient.set_config('syzygy', BUILD_CONFIG='Debug', GIT_MODE=True)

elif buildername == 'Syzygy Coverage':

api.syzygy.set_config('syzygy', BUILD_CONFIG='Coverage')

api.chromium.set_config('syzygy', BUILD_CONFIG='Coverage')

- api.gclient.set_config('syzygy', BUILD_CONFIG='Coverage')

+ api.gclient.set_config('syzygy', BUILD_CONFIG='Coverage', GIT_MODE=True)

else:

assert buildername == 'Syzygy Official'

api.syzygy.set_config('syzygy_official')

api.chromium.set_config('syzygy_official')

- api.gclient.set_config('syzygy_official')

+ api.gclient.set_config('syzygy_official', GIT_MODE=True)

# Clean up any running processes on the slave.

api.syzygy.taskkill()

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/syzygy/example.expected/full_master_client_syzygy_Syzygy_Coverage.json » ('j') | no next file with comments »