Issue 22756002: Reverting nacl_fixup_ldso.py sections change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22756002: Reverting nacl_fixup_ldso.py sections change. (Closed)

Created:
7 years, 4 months ago by bradn

Modified:
7 years, 4 months ago

Reviewers:
Mark Seaborn, Roland McGrath

CC:
native-client-reviews_googlegroups.com

Base URL:
http://git.chromium.org/native_client/nacl-glibc.git@master

Visibility:
Public.

Reverting nacl_fixup_ldso.py sections change. It turns out the loader does not actually allow all of the sections our glibc toolchain emits (PT_DYNAMIC + rw in particular). We should fix this, but for now making an ABI breaking change is undesirable. BUG=None TEST=trybots R=mseaborn@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-glibc.git;a=commit;h=990e7c4

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	elf/nacl_fixup_ldso.py	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

bradn

7 years, 4 months ago (2013-08-09 22:01:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r990e7c4 (presubmit successful).