Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1496)

Unified Diff: elf/nacl_fixup_ldso.py

Issue 22756002: Reverting nacl_fixup_ldso.py sections change. (Closed) Base URL: http://git.chromium.org/native_client/nacl-glibc.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: elf/nacl_fixup_ldso.py
diff --git a/elf/nacl_fixup_ldso.py b/elf/nacl_fixup_ldso.py
index 4084d6d458613519dadd2efac742e65ffbbaf131..a5eb1f9eea1e32680b10909f76a2c97bb4ab61b1 100644
--- a/elf/nacl_fixup_ldso.py
+++ b/elf/nacl_fixup_ldso.py
@@ -43,6 +43,19 @@ def main(args):
check("B", offset_e_type, ET_DYN)
replace("B", offset_e_type, ET_EXEC)
+ # sel_ldr rejects ELF Program Headers other than PT_LOAD.
+ # Drop PT_DYNAMIC, PT_GNU_STACK and PT_TLS.
+ fh.seek(offset_ei_class)
+ elfclass = fh.read(1)
+ if elfclass == elfclass32:
+ check("H", offset_e_phnum32, 7)
+ replace("H", offset_e_phnum32, 3)
+ elif elfclass == elfclass64:
+ check("H", offset_e_phnum64, 7)
+ replace("H", offset_e_phnum64, 3)
+ else:
+ raise AssertionError("Unknown ELF class in file %s." % filename)
+
fh.close()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698