Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Unified Diff: base/files/file_proxy_unittest.cc

Issue 2275553005: //base: Make ScopedTempDir::path() a GetPath() with a DCHECK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a hint to the DCHECK Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/files/file_proxy_unittest.cc
diff --git a/base/files/file_proxy_unittest.cc b/base/files/file_proxy_unittest.cc
index 2c157a54e9b98b916bcb0c56aadd8f238180895d..87ceaf74e0601d058676247f282ddd6a7283ef73 100644
--- a/base/files/file_proxy_unittest.cc
+++ b/base/files/file_proxy_unittest.cc
@@ -88,8 +88,10 @@ class FileProxyTest : public testing::Test {
TaskRunner* file_task_runner() const {
return file_thread_.task_runner().get();
}
- const FilePath& test_dir_path() const { return dir_.path(); }
- const FilePath test_path() const { return dir_.path().AppendASCII("test"); }
+ const FilePath& test_dir_path() const { return dir_.GetPath(); }
danakj 2016/09/07 20:47:18 Can you name these not-hacker-case too?
vabr (Chromium) 2016/09/08 07:45:35 Done.
+ const FilePath test_path() const {
+ return dir_.GetPath().AppendASCII("test");
+ }
ScopedTempDir dir_;
MessageLoopForIO message_loop_;

Powered by Google App Engine
This is Rietveld 408576698