//base: Make ScopedTempDir::path() a GetPath() with a DCHECK

base/files/file_proxy_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_proxy.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <utility>
@@ skipping 70 matching lines @@
     proxy->CreateOrOpen(
         test_path(), flags,
         Bind(&FileProxyTest::DidCreateOrOpen, weak_factory_.GetWeakPtr()));
     RunLoop().Run();
     EXPECT_TRUE(proxy->IsValid());
   }
 
   TaskRunner* file_task_runner() const {
     return file_thread_.task_runner().get();
   }
-  const FilePath& test_dir_path() const { return dir_.path(); }
-  const FilePath test_path() const { return dir_.path().AppendASCII("test"); }
+  const FilePath& test_dir_path() const { return dir_.GetPath(); }

[danakj, 2016/09/07 20:47:18]

Can you name these not-hacker-case too?

[vabr (Chromium), 2016/09/08 07:45:35]

Done.

+  const FilePath test_path() const {
+    return dir_.GetPath().AppendASCII("test");
+  }
 
   ScopedTempDir dir_;
   MessageLoopForIO message_loop_;
   Thread file_thread_;
 
   File::Error error_;
   FilePath path_;
   File::Info file_info_;
   std::vector<char> buffer_;
   int bytes_written_;
@@ skipping 288 matching lines @@
   char buffer[53];
   EXPECT_EQ(53, base::ReadFile(test_path(), buffer, 53));
   int i = 0;
   for (; i < 10; ++i)
     EXPECT_EQ(kTestData[i], buffer[i]);
   for (; i < 53; ++i)
     EXPECT_EQ(0, buffer[i]);
 }
 
 }  // namespace base