Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2275453002:
MD WebUI: Fix misaligned spinner in narrow-mode cr-toolbar (Closed)
|
Created:
4 years, 4 months ago by tsergeant Modified:
4 years, 3 months ago Reviewers:
Dan Beam CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, dbeam+watch-elements_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD WebUI: Fix misaligned spinner in narrow-mode cr-toolbar
In narrow mode, the spinner was not positioned with the same margin as
the search icon, causing it to incorrectly appear to the left of the
icon.
BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/950f9975599768b6a08c7146cb4befa161be87aa
Cr-Commit-Position: refs/heads/master@{#414035}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Use webkit-margin-start #
Total comments: 3
Messages
Total messages: 31 (14 generated)
Description was changed from ========== MD WebUI: Fix misaligned spinner in narrow-mode cr-toolbar In narrow mode, the spinner was not positioned with the same margin as the search icon, causing it to incorrectly appear to the left of the icon. BUG=None ========== to ========== MD WebUI: Fix misaligned spinner in narrow-mode cr-toolbar In narrow mode, the spinner was not positioned with the same margin as the search icon, causing it to incorrectly appear to the left of the icon. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
tsergeant@chromium.org changed reviewers: + dbeam@chromium.org
The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2275453002/diff/1/ui/webui/resources/cr_eleme... File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html (right): https://codereview.chromium.org/2275453002/diff/1/ui/webui/resources/cr_eleme... ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html:117: { wrap it
https://codereview.chromium.org/2275453002/diff/1/ui/webui/resources/cr_eleme... File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html (right): https://codereview.chromium.org/2275453002/diff/1/ui/webui/resources/cr_eleme... ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html:117: { On 2016/08/23 23:16:05, Dan Beam wrote: > wrap it Do you mean like: :host-context([dir=ltr]):host([narrow][showing-search]) paper-spinner-lite {
https://codereview.chromium.org/2275453002/diff/1/ui/webui/resources/cr_eleme... File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html (right): https://codereview.chromium.org/2275453002/diff/1/ui/webui/resources/cr_eleme... ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html:117: { On 2016/08/23 23:22:19, tsergeant wrote: > On 2016/08/23 23:16:05, Dan Beam wrote: > > wrap it > > Do you mean like: > > :host-context([dir=ltr]):host([narrow][showing-search]) > paper-spinner-lite { quit horsin' around[1], and just use -webkit-margin-start + transition: margin like this https://jsfiddle.net/tg8q8Ltf/ [1] https://www.youtube.com/watch?v=a1d1S58P0nc
lgtm
https://codereview.chromium.org/2275453002/diff/1/ui/webui/resources/cr_eleme... File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html (right): https://codereview.chromium.org/2275453002/diff/1/ui/webui/resources/cr_eleme... ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html:117: { On 2016/08/23 23:36:43, Dan Beam wrote: > On 2016/08/23 23:22:19, tsergeant wrote: > > On 2016/08/23 23:16:05, Dan Beam wrote: > > > wrap it > > > > Do you mean like: > > > > :host-context([dir=ltr]):host([narrow][showing-search]) > > paper-spinner-lite { > > quit horsin' around[1], and just use -webkit-margin-start + transition: margin > like this https://jsfiddle.net/tg8q8Ltf/ > > [1] https://www.youtube.com/watch?v=a1d1S58P0nc [grasping at straws] is that Character Actress Margin Margindale? (Done) https://codereview.chromium.org/2275453002/diff/20001/ui/webui/resources/cr_e... File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html (right): https://codereview.chromium.org/2275453002/diff/20001/ui/webui/resources/cr_e... ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html:35: transition: margin 150ms, opacity 200ms; I even already had the right transition property set.
The CQ bit was checked by tsergeant@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by tsergeant@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by tsergeant@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by tsergeant@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== MD WebUI: Fix misaligned spinner in narrow-mode cr-toolbar In narrow mode, the spinner was not positioned with the same margin as the search icon, causing it to incorrectly appear to the left of the icon. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD WebUI: Fix misaligned spinner in narrow-mode cr-toolbar In narrow mode, the spinner was not positioned with the same margin as the search icon, causing it to incorrectly appear to the left of the icon. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/950f9975599768b6a08c7146cb4befa161be87aa Cr-Commit-Position: refs/heads/master@{#414035} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/950f9975599768b6a08c7146cb4befa161be87aa Cr-Commit-Position: refs/heads/master@{#414035}
Message was sent while issue was closed.
https://codereview.chromium.org/2275453002/diff/20001/ui/webui/resources/cr_e... File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html (right): https://codereview.chromium.org/2275453002/diff/20001/ui/webui/resources/cr_e... ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html:111: :host-context([dir=ltr]):host([narrow][showing-search]) wait, why are these dir=ltr?
Message was sent while issue was closed.
https://codereview.chromium.org/2275453002/diff/20001/ui/webui/resources/cr_e... File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html (right): https://codereview.chromium.org/2275453002/diff/20001/ui/webui/resources/cr_e... ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html:111: :host-context([dir=ltr]):host([narrow][showing-search]) On 2016/08/29 20:53:04, Dan Beam wrote: > wait, why are these dir=ltr? aww beans, that was just me forgetting to change the full selector. I'll put up a CL shortly. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
