MD WebUI: Fix misaligned spinner in narrow-mode cr-toolbar

ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-input/iron-input.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input-container.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-spinner/paper-spinner-lite.html">
 <link rel="import" href="chrome://resources/cr_elements/cr_search_field/cr_search_field_behavior.html">
 <link rel="import" href="chrome://resources/cr_elements/icons.html">
 
 <dom-module id="cr-toolbar-search-field">
   <template>
@@ skipping 14 matching lines @@
       paper-icon-button {
         height: 32px;
         margin: 6px;
         min-width: 32px;
         padding: 6px;
         width: 32px;
       }
 
       #icon {
         --paper-icon-button-ink-color: white;
         transition: margin 150ms, opacity 200ms;

[tsergeant, 2016/08/23 23:51:32]

I even already had the right transition property set.

       }
 
       #prompt {
         opacity: 0;
       }
 
       paper-spinner-lite {
         --paper-spinner-color: white;
         height: 20px;
         margin: 0 6px;
@@ skipping 54 matching lines @@
 
       /* Search open. */
       :host([showing-search][spinner-active]) #icon {
         opacity: 0;
       }
 
       :host([narrow][showing-search]) {
         width: 100%;
       }
 
-      /*
-       * Margin needs to be animated to prevent jumping around during
-       * opening/closing. -webkit-margin-start is not animatable, so we have to
-       * use regular margin-left/right instead.
-       */
-      :host-context([dir=ltr]):host([narrow][showing-search]) #icon {
-        margin-left: 18px;
-      }
-
-      :host-context([dir=rtl]):host([narrow][showing-search]) #icon {
-        margin-right: 18px;
+      :host-context([dir=ltr]):host([narrow][showing-search]) #icon,
+      :host-context([dir=ltr]):host([narrow][showing-search])

[Dan Beam, 2016/08/29 20:53:04]

wait, why are these dir=ltr?

[tsergeant, 2016/08/29 22:51:41]

aww beans, that was just me forgetting to change the full selector. I'll put up
a CL shortly.

+          paper-spinner-lite {
+        -webkit-margin-start: 18px;
       }
     </style>
     <paper-spinner-lite
         active="[[isSpinnerShown_(spinnerActive, showingSearch)]]">
     </paper-spinner-lite>
     <paper-icon-button id="icon" icon="cr:search" title="[[label]]"
         tabindex$="[[computeIconTabIndex_(narrow)]]">
     </paper-icon-button>
     <paper-input-container id="searchTerm" on-search="onSearchTermSearch"
         on-keydown="onSearchTermKeydown" no-label-float>
       <label id="prompt" for="searchInput">[[label]]</label>
       <input is="iron-input" id="searchInput" type="search"
           on-blur="onInputBlur_" incremental></input>
     </paper-input-container>
     <paper-icon-button icon="cr:cancel" id="clearSearch"
         title="[[clearLabel]]" hidden$="[[!hasSearchText_]]"
         on-tap="hideSearch_">
     </paper-icon-button>
   </template>
   <script src="cr_toolbar_search_field.js"></script>
 </dom-module>