Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/perf/measurements/dromaeo.py

Issue 22754003: Refactor BenchmarkResult.Add to take enum for data_type (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/android/pylib/perf_tests_helper.py ('K') | « tools/perf/benchmarks/sunspider.py ('k') | tools/perf/measurements/rasterize_and_record.py » ('j') | tools/telemetry/telemetry/page/result_data_type.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/dromaeo.py
===================================================================
--- tools/perf/measurements/dromaeo.py (revision 217866)
+++ tools/perf/measurements/dromaeo.py (working copy)
@@ -4,6 +4,7 @@
from telemetry.core import util
from telemetry.page import page_measurement
+from telemetry.page import result_data_type
class Dromaeo(page_measurement.PageMeasurement):
def MeasurePage(self, page, tab, results):
@@ -24,7 +25,7 @@
suffix = page.url[page.url.index('?') + 1 : page.url.index('&')]
for k, v in score.iteritems():
- data_type = 'unimportant'
+ data_type = result_data_type.UNIMPORTANT
if k == suffix:
- data_type = 'default'
+ data_type = result_data_type.DEFAULT
results.Add(Escape(k), 'runs/s', v, data_type=data_type)
« build/android/pylib/perf_tests_helper.py ('K') | « tools/perf/benchmarks/sunspider.py ('k') | tools/perf/measurements/rasterize_and_record.py » ('j') | tools/telemetry/telemetry/page/result_data_type.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698