Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1560)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/perf/benchmarks/sunspider.py

Issue 22754003: Refactor BenchmarkResult.Add to take enum for data_type (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/android/pylib/perf_tests_helper.py ('K') | « tools/perf/benchmarks/spaceport.py ('k') | tools/perf/measurements/dromaeo.py » ('j') | tools/telemetry/telemetry/page/result_data_type.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/sunspider.py
===================================================================
--- tools/perf/benchmarks/sunspider.py (revision 217866)
+++ tools/perf/benchmarks/sunspider.py (working copy)
@@ -8,6 +8,7 @@
from telemetry import test
from telemetry.core import util
from telemetry.page import page_measurement
+from telemetry.page import result_data_type
from telemetry.page import page_set
@@ -33,7 +34,7 @@
total += value
totals.append(total)
for key, values in r.iteritems():
- results.Add(key, 'ms', values, data_type='unimportant')
+ results.Add(key, 'ms', values, data_type=result_data_type.UNIMPORTANT)
results.Add('Total', 'ms', totals)
« build/android/pylib/perf_tests_helper.py ('K') | « tools/perf/benchmarks/spaceport.py ('k') | tools/perf/measurements/dromaeo.py » ('j') | tools/telemetry/telemetry/page/result_data_type.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698