Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: tools/perf/benchmarks/octane.py

Issue 22754003: Refactor BenchmarkResult.Add to take enum for data_type (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/octane.py
===================================================================
--- tools/perf/benchmarks/octane.py (revision 217866)
+++ tools/perf/benchmarks/octane.py (working copy)
@@ -7,6 +7,7 @@
from telemetry import test
from telemetry.core import util
from telemetry.page import page_measurement
+from telemetry.page import result_data_type
from telemetry.page import page_set
@@ -36,9 +37,9 @@
for key, value in result_dict.iteritems():
if value == '...':
continue
- data_type = 'unimportant'
+ data_type = result_data_type.UNIMPORTANT
if key == 'score':
- data_type = 'default'
+ data_type = result_data_type.DEFAULT
results.Add(key, 'score (bigger is better)', value, data_type=data_type)

Powered by Google App Engine
This is Rietveld 408576698