Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/perf/benchmarks/kraken.py

Issue 22754003: Refactor BenchmarkResult.Add to take enum for data_type (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/android/pylib/perf_tests_helper.py ('K') | « tools/perf/benchmarks/dom_perf.py ('k') | tools/perf/benchmarks/octane.py » ('j') | tools/telemetry/telemetry/page/result_data_type.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/kraken.py
===================================================================
--- tools/perf/benchmarks/kraken.py (revision 217866)
+++ tools/perf/benchmarks/kraken.py (working copy)
@@ -9,6 +9,7 @@
from telemetry import test
from telemetry.core import util
from telemetry.page import page_measurement
+from telemetry.page import result_data_type
from telemetry.page import page_set
@@ -34,7 +35,7 @@
for key in result_dict:
if key == 'v':
continue
- results.Add(key, 'ms', result_dict[key], data_type='unimportant')
+ results.Add(key, 'ms', result_dict[key], result_data_type.UNIMPORTANT)
total += _Mean(result_dict[key])
results.Add('Total', 'ms', total)
« build/android/pylib/perf_tests_helper.py ('K') | « tools/perf/benchmarks/dom_perf.py ('k') | tools/perf/benchmarks/octane.py » ('j') | tools/telemetry/telemetry/page/result_data_type.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698