tools/telemetry/telemetry/core/chrome/android_browser_finder.py - Issue 22754003: Refactor BenchmarkResult.Add to take enum for data_type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/chrome/android_browser_finder.py

Issue 22754003: Refactor BenchmarkResult.Add to take enum for data_type (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/core/chrome/android_browser_finder.py

===================================================================

--- tools/telemetry/telemetry/core/chrome/android_browser_finder.py (revision 218037)

+++ tools/telemetry/telemetry/core/chrome/android_browser_finder.py (working copy)

@@ -103,7 +103,7 @@

adb_works = False

if adb_works and sys.platform.startswith('linux'):

# Workaround for crbug.com/268450

- import psutil

+ import psutil # pylint: disable=F0401

adb_commands.GetAttachedDevices()

pids = [p.pid for p in psutil.process_iter() if 'adb' in p.name]

with open(os.devnull, 'w') as devnull: