Refactor BenchmarkResult.Add to take enum for data_type

tools/perf/metrics/smoothness.py

Index: tools/perf/metrics/smoothness.py
===================================================================
--- tools/perf/metrics/smoothness.py	(revision 222891)
+++ tools/perf/metrics/smoothness.py	(working copy)
@@ -6,6 +6,10 @@
 from telemetry.core import util
 from metrics import discrepancy
 
+# Get build scripts into our path.
+util.AddDirToPythonPath(util.GetChromiumSrcDir(), 'build', 'util', 'lib')
+from common import perf_result_data_type # pylint: disable=F0401
+
 TIMELINE_MARKER = 'smoothness_scroll'
 
 class SmoothnessMetrics(object):
@@ -159,24 +163,24 @@
   results.Add('dropped_percent', '%',
               Average(s.dropped_frame_count,
                       s.screen_frame_count + s.dropped_frame_count, 100, 1),
-              data_type='unimportant')
+              data_type=perf_result_data_type.UNIMPORTANT)
   results.Add('percent_impl_scrolled', '%',
               Average(s.impl_thread_scroll_count,
                       s.impl_thread_scroll_count +
                       s.main_thread_scroll_count,
                       100, 1),
-              data_type='unimportant')
+              data_type=perf_result_data_type.UNIMPORTANT)
   results.Add('average_num_layers_drawn', '',
               Average(s.drawn_layer_count, s.screen_frame_count, 1, 1),
-              data_type='unimportant')
+              data_type=perf_result_data_type.UNIMPORTANT)
   results.Add('average_num_missing_tiles', '',
               Average(s.missing_tile_count, s.screen_frame_count, 1, 1),
-              data_type='unimportant')
+              data_type=perf_result_data_type.UNIMPORTANT)
 
   # Texture Upload Results
   results.Add('average_commit_time', 'ms',
               Average(s.commit_time, s.commit_count, 1000, 3),
-              data_type='unimportant')
+              data_type=perf_result_data_type.UNIMPORTANT)
   results.Add('texture_upload_count', 'count',
               Total(s.texture_upload_count))
   results.Add('total_texture_upload_time', 'seconds',
@@ -185,43 +189,43 @@
   # Image Decoding Results
   results.Add('total_deferred_image_decode_count', 'count',
               Total(s.deferred_image_decode_count),
-              data_type='unimportant')
+              data_type=perf_result_data_type.UNIMPORTANT)
   results.Add('total_image_cache_hit_count', 'count',
               Total(s.deferred_image_cache_hit_count),
-              data_type='unimportant')
+              data_type=perf_result_data_type.UNIMPORTANT)
   results.Add('average_image_gathering_time', 'ms',
               Average(s.image_gathering_time, s.image_gathering_count,
                       1000, 3),
-              data_type='unimportant')
+              data_type=perf_result_data_type.UNIMPORTANT)
   results.Add('total_deferred_image_decoding_time', 'seconds',
               Total(s.deferred_image_decode_time),
-              data_type='unimportant')
+              data_type=perf_result_data_type.UNIMPORTANT)
 
   # Tile Analysis Results
   results.Add('total_tiles_analyzed', 'count',
               Total(s.tile_analysis_count),
-              data_type='unimportant')
+              data_type=perf_result_data_type.UNIMPORTANT)
   results.Add('solid_color_tiles_analyzed', 'count',
               Total(s.solid_color_tile_analysis_count),
-              data_type='unimportant')
+              data_type=perf_result_data_type.UNIMPORTANT)
   results.Add('average_tile_analysis_time', 'ms',
               Average(s.tile_analysis_time, s.tile_analysis_count,
                       1000, 3),
-              data_type='unimportant')
+              data_type=perf_result_data_type.UNIMPORTANT)
 
   # Latency Results
   results.Add('average_latency', 'ms',
               Average(s.input_event_latency, s.input_event_count,
                       1000, 3),
-              data_type='unimportant')
+              data_type=perf_result_data_type.UNIMPORTANT)
   results.Add('average_touch_ui_latency', 'ms',
               Average(s.touch_ui_latency, s.touch_ui_count, 1000, 3),
-              data_type='unimportant')
+              data_type=perf_result_data_type.UNIMPORTANT)
   results.Add('average_touch_acked_latency', 'ms',
               Average(s.touch_acked_latency, s.touch_acked_count,
                       1000, 3),
-              data_type='unimportant')
+              data_type=perf_result_data_type.UNIMPORTANT)
   results.Add('average_scroll_update_latency', 'ms',
               Average(s.scroll_update_latency, s.scroll_update_count,
                       1000, 3),
-              data_type='unimportant')
+              data_type=perf_result_data_type.UNIMPORTANT)