Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2275343002: Stopping cached AudioOutputDevices on AudioRendererSinkCache destruction. (Closed)

Created:
4 years, 3 months ago by o1ka
Modified:
4 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stopping cached AudioOutputDevices on AudioRendererSinkCache destruction. BUG=640576 Committed: https://crrev.com/7c54ad8cf953810135f3684e4eada4c5625efe1c Cr-Commit-Position: refs/heads/master@{#415296}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M content/renderer/media/audio_renderer_sink_cache_impl.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 29 (19 generated)
o1ka
PTAL
4 years, 3 months ago (2016-08-25 15:28:44 UTC) #4
DaleCurtis
lgtm
4 years, 3 months ago (2016-08-25 17:50:36 UTC) #7
Henrik Grunell
lgtm
4 years, 3 months ago (2016-08-26 07:47:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275343002/1
4 years, 3 months ago (2016-08-26 10:19:33 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/281861)
4 years, 3 months ago (2016-08-26 12:21:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275343002/1
4 years, 3 months ago (2016-08-29 16:04:27 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/132105)
4 years, 3 months ago (2016-08-29 17:01:04 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275343002/1
4 years, 3 months ago (2016-08-30 14:46:38 UTC) #26
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 14:50:42 UTC) #27
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 14:52:17 UTC) #29
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c54ad8cf953810135f3684e4eada4c5625efe1c
Cr-Commit-Position: refs/heads/master@{#415296}

Powered by Google App Engine
This is Rietveld 408576698