Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 2275323002: MIPS: Fix crahses of tests unittests/AstDecoderTest.Float[32|64]Const on architectures that do not … (Closed)

Created:
4 years, 3 months ago by ivica.bogosavljevic
Modified:
4 years, 3 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix crahses of tests unittests/AstDecoderTest.Float[32|64]Const on architectures that do not support missaligned memory access BUG=unittests/AstDecoderTest.Float64Const, unittests/AstDecoderTest.Float32Const Committed: https://crrev.com/db56339952c936d41f8ee99635a6d6f424d1730b Cr-Commit-Position: refs/heads/master@{#38941}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/unittests/wasm/ast-decoder-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ivica.bogosavljevic
PTAL
4 years, 3 months ago (2016-08-25 14:04:20 UTC) #3
titzer
lgtm
4 years, 3 months ago (2016-08-26 08:25:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275323002/1
4 years, 3 months ago (2016-08-26 11:55:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 12:29:48 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 12:30:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db56339952c936d41f8ee99635a6d6f424d1730b
Cr-Commit-Position: refs/heads/master@{#38941}

Powered by Google App Engine
This is Rietveld 408576698