Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: test/unittests/wasm/ast-decoder-unittest.cc

Issue 2275323002: MIPS: Fix crahses of tests unittests/AstDecoderTest.Float[32|64]Const on architectures that do not … (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/wasm/ast-decoder-unittest.cc
diff --git a/test/unittests/wasm/ast-decoder-unittest.cc b/test/unittests/wasm/ast-decoder-unittest.cc
index 7311f063a0ad8984ab47808cd8120ecb8dd8decb..51caee271071e20f94f7fcc0c96b261d25b3269e 100644
--- a/test/unittests/wasm/ast-decoder-unittest.cc
+++ b/test/unittests/wasm/ast-decoder-unittest.cc
@@ -207,7 +207,7 @@ TEST_F(AstDecoderTest, Float32Const) {
byte code[] = {kExprF32Const, 0, 0, 0, 0};
float* ptr = reinterpret_cast<float*>(code + 1);
for (int i = 0; i < 30; i++) {
- *ptr = i * -7.75f;
+ WriteLittleEndianValue<float>(ptr, i * -7.75f);
EXPECT_VERIFIES(sigs.f_ff(), code);
}
}
@@ -216,7 +216,7 @@ TEST_F(AstDecoderTest, Float64Const) {
byte code[] = {kExprF64Const, 0, 0, 0, 0, 0, 0, 0, 0};
double* ptr = reinterpret_cast<double*>(code + 1);
for (int i = 0; i < 30; i++) {
- *ptr = i * 33.45;
+ WriteLittleEndianValue<double>(ptr, i * 33.45);
EXPECT_VERIFIES(sigs.d_dd(), code);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698