Issue 22751007: Linux: use sandbox binary alongside chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22751007: Linux: use sandbox binary alongside chrome. (Closed)

Created:
7 years, 4 months ago by Paweł Hajdan Jr.

Modified:
7 years, 4 months ago

Reviewers:
Avi (use Gerrit), jln (very slow on Chromium)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Linux: use sandbox binary alongside chrome. This removes linux_sandbox_path and instead expects sandbox binary to be in the same directory as chrome (or CHROME_DEVEL_SANDBOX to be set). This will be helpful for SxS support on Linux, where the sandbox path would be different depending on channel. This is a resubmit of https://codereview.chromium.org/20197003 with a bug fix that makes --no-sandbox work properly. TBR=jln@chromium.org BUG=38598 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216746

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -41 lines)			Patch
M	build/common.gypi	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	content/browser/browser_main_loop.cc	View	2 chunks	+36 lines, -28 lines	0 comments	Download
M	content/content_browser.gypi	View	1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jln (very slow on Chromium)

Please, next time upload the original patch as PS#1 and the modifications as PS#2, it's ...

7 years, 4 months ago (2013-08-09 19:27:17 UTC) #2

Paweł Hajdan Jr.

Committed patchset #1 manually as r216746 (presubmit successful).

7 years, 4 months ago (2013-08-09 20:43:40 UTC) #3

Paweł Hajdan Jr.

7 years, 4 months ago (2013-08-09 20:44:12 UTC) #4

Message was sent while issue was closed.

Avi: TBR, OWNERS already reviewed in previous version of this CL.

Expand Messages | Collapse Messages